Page MenuHomeFreeBSD

tcpdump: Reconnect pfsync printer
ClosedPublic

Authored by jrm on Jun 16 2023, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 30, 12:46 AM
Unknown Object (File)
Sun, Sep 29, 4:48 PM
Unknown Object (File)
Fri, Sep 27, 5:15 AM
Unknown Object (File)
Mon, Sep 23, 6:09 AM
Unknown Object (File)
Sun, Sep 22, 8:05 PM
Unknown Object (File)
Sun, Sep 22, 4:58 AM
Unknown Object (File)
Thu, Sep 19, 5:42 AM
Unknown Object (File)
Wed, Sep 18, 2:22 PM
Subscribers

Details

Summary

Fixes: ee67461e (tpcdump: Update to 4.99.4)

Test Plan

It looks like I missed hooking in the pfsync printer in ee67461e. I think I messed up when redoing the sub-tree merge of vendor/tcpdump to contrib/tcpdump after 4bf98559. This is the only test I've done so far.

make -C /usr/src/usr.sbin/tcpdump clean
make -C /usr/src/usr.sbin/tcpdump
make -C /usr/src/usr.sbin/tcpdump install
sudo /usr/sbin/tcpdump -i pfsync0

After restarting pf, tcpdump shows

tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
listening on pfsync0, link-type PFSYNC (Packet filter state syncing), snapshot length 262144 bytes
19:47:11.484907 19:47:11.484907 PFSYNCv5 len 48
    clear all count 1
    eof count 1^J

Any suggestions for further tests?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52105
Build 48996: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Jun 16 2023, 2:39 PM
jrm edited the test plan for this revision. (Show Details)
jrm edited the test plan for this revision. (Show Details)
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: kp, emaste.
This revision is now accepted and ready to land.Jun 17 2023, 7:54 AM
This revision was automatically updated to reflect the committed changes.