Paths

Table of Contentst

Differential D40131

Add helpers to allocate an arm64 VFP state struct
ClosedPublic
Actions

Authored by andrew on May 17 2023, 11:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 27, 10:22 AM

	Unknown Object (File)
	Tue, Sep 24, 7:43 PM

	Unknown Object (File)
	Mon, Sep 23, 10:13 PM

	Unknown Object (File)
	Fri, Sep 20, 6:34 PM

	Unknown Object (File)
	Tue, Sep 17, 12:35 PM

	Unknown Object (File)
	Mon, Sep 16, 10:50 PM

	Unknown Object (File)
	Mon, Sep 16, 12:50 AM

	Unknown Object (File)
	Tue, Sep 10, 4:45 AM

View All 72 Files

Subscribers

Details

Reviewers

manu
markj

Group Reviewers

Commits

rGdf0d0fc99093: Add helpers to allocate an arm64 VFP state struct

Summary

This will be used by bhyve and will allow the size to change, e.g. for SVE.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.May 17 2023, 11:34 AM

Herald added a reviewer: manu. · View Herald TranscriptMay 17 2023, 11:34 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.May 17 2023, 11:34 AM

andrew added a parent revision: D40130: Export arm64 VFP handling functions.

Harbormaster completed remote builds in B51522: Diff 122037.May 17 2023, 11:34 AM

andrew added a reviewer: markj.May 17 2023, 11:35 AM

~~Clean up vmm stats~~ git arc with wrong commit...

Harbormaster completed remote builds in B51554: Diff 122123.May 19 2023, 3:31 PM

markj added inline comments.May 22 2023, 2:27 PM

sys/arm64/arm64/vfp.c
63	The whitespace after `static` looks odd.
288	Now this is only called from APs, so the name is a bit misleading. Maybe vfp_init_secondary() (and plain vfp_init() below)?
313	I think we prefer _Alignof.
473	No need for blank lines at the beginning of functions.

Update based on feedback from @markj

Harbormaster completed remote builds in B52395: Diff 124115.Jul 3 2023, 12:13 PM

markj accepted this revision.Jul 4 2023, 2:34 PM

This revision is now accepted and ready to land.Jul 4 2023, 2:34 PM

Closed by commit rGdf0d0fc99093: Add helpers to allocate an arm64 VFP state struct (authored by andrew). · Explain WhyJul 5 2023, 9:47 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGdf0d0fc99093: Add helpers to allocate an arm64 VFP state struct.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

2 lines

57 lines

include/

6 lines

Diff 124187

sys/arm64/arm64/mp_machdep.c

Loading...

sys/arm64/arm64/vfp.c

Loading...

sys/arm64/include/vfp.h

Loading...