bhyve: pci_devinst.pi_name should contain bus, slot, func

[gusev.vitaliy_gmail.com]

Summary

Each device needs a unique identifier to store and restore snapshots
properly. Adding the pci bsf information to the device name creates a
unique identifier as a bsf can't be occupied twice.

Related to multiple devices support.

Sponsored by: vStack

Test Plan

Note, pdi.pi_name is changed, for example, to: "virtio-net@pci.0.4.0"

[corvink]

usr.sbin/bhyve/pci_emul.c

1032

We may like to use the same format as pciconf pci%s:%s:%s:%s, domain, bus, slot, func.

[gusev.vitaliy_gmail.com]

usr.sbin/bhyve/pci_emul.c

1032

Yes, but currently this format is more useful since .meta file doesn't have command line. This format has 'emu' type and it is important.

The best is enemy of good :)

[corvink]

usr.sbin/bhyve/pci_emul.c

1032

Sry to be unclear. I've only talked to the pci part. So, I suggested to use %s@pci%s:%s:%s:%s, emu, domain, bus, slot, func.

[gusev.vitaliy_gmail.com]

usr.sbin/bhyve/pci_emul.c

1032

Hmm, I can't find domain in bhyve source directory.

[corvink]

usr.sbin/bhyve/pci_emul.c

1032

Afaik, domain isn't supported by bhyve yet. So, we can hard code it to 0.

[gusev.vitaliy_gmail.com]

usr.sbin/bhyve/pci_emul.c

1032

It seems that domain can be added when becomes supported.