Page MenuHomeFreeBSD

bhyve: [snapshot] Rename 'structs' key with 'kern_structs'
ClosedPublic

Authored by gusev.vitaliy_gmail.com on May 15 2023, 1:48 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Apr 24, 10:31 PM
Unknown Object (File)
Sat, Apr 19, 3:47 AM
Unknown Object (File)
Mon, Apr 14, 11:56 AM
Unknown Object (File)
Mon, Apr 14, 5:18 AM
Unknown Object (File)
Mon, Apr 14, 1:26 AM
Unknown Object (File)
Sun, Apr 13, 11:02 PM
Unknown Object (File)
Feb 25 2025, 4:04 PM
Unknown Object (File)
Jan 27 2025, 8:20 AM

Details

Summary

Using key 'structs' is ambiguous. This section contains data
related to the kernel. It should use a more informative naming.

Sponsored by: vStack

Related to multiple devices support.

Test Plan

Note,

.meta file contents is changed:
From "structs": [
to "kern_structs": [

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 15 2023, 5:24 PM

One general note: Please try to explain why a change is required in your commit message. "Related to xy" is not enough. It should explain why it is related to xy and what's the advantage of the patch.

gusev.vitaliy_gmail.com retitled this revision from bhyve: [snapshot] Rename 'struct' key with 'kern_struct' to bhyve: [snapshot] Rename 'struct's key with 'kern_structs'.Jun 14 2023, 12:01 AM
gusev.vitaliy_gmail.com edited the summary of this revision. (Show Details)
gusev.vitaliy_gmail.com retitled this revision from bhyve: [snapshot] Rename 'struct's key with 'kern_structs' to bhyve: [snapshot] Rename 'structs' key with 'kern_structs'.Jun 14 2023, 12:05 AM