fwget: simplify adding firmware images to pkg to install

[bz]

Summary

Rather than using echo to return the firmware package name, call a
new function (addpkg) which will also deal with (i) no leading space
and (ii) remove duplicates (as some devices have dual-wifi-cards).
In addition we won't have a line break when having multiple packages.

While here also do not call pkg(8) anymore if there is no package to
install and actually use the variable to install all and not just the
last found package.

[manu]

In that case we can also remove all the shell redirection since we do not echo anymore and the log functions can just echo directly.
Otherwise lgtm

[bz]

In D40071#912590, @manu wrote:

In that case we can also remove all the shell redirection since we do not echo anymore and the log functions can just echo directly.
Otherwise lgtm

Cool. Would you mind if I do that as a 4th change on top of the current stack?

[bapt]

usr.sbin/fwget/fwget.sh

75

this is not working:

addpkg mysuperpackage
addpkg super
echo $packages
mysuperpackages

If you want deduplication to work you need to change it to:

case " ${packages} " in
* ${_p} *) ;; #duplicate
*) packages="${packages} ${_p}" ;;
esac

note the new spaces

[bz]

usr.sbin/fwget/fwget.sh

75

To my understanding this doesn't work either as the first one doesn't have a leading space and the last one in the list does not have a trailing one.
Almost have to iterate over $packages and check for an exact match?

[bapt]

usr.sbin/fwget/fwget.sh

75

no this will always work because I added space both around "${packages}" and *\ ${_p}\ *) ;;

[bz]

usr.sbin/fwget/fwget.sh

75

Oh doh! I missed the former. I'll update the change immediately.

[bz]

Fix dedup as reported by @bapt.

[bz]

usr.sbin/fwget/fwget.sh

75

Had to add extra \ for the spaces to avoid errors by sh

[bz]

ping6?