Page MenuHomeFreeBSD
Differential D40040

bhyve: read OpRegion address and size for GVT-d
ClosedPublic
Actions

Authored by corvink on May 10 2023, 12:45 PM.
Tags
None
Referenced Files
F102553053: D40040.diff
Wed, Nov 13, 11:25 PM
Unknown Object (File)
Sat, Oct 26, 1:20 AM
Unknown Object (File)
Fri, Oct 25, 6:43 PM
Unknown Object (File)
Sep 24 2024, 5:51 AM
Unknown Object (File)
Sep 24 2024, 3:06 AM
Unknown Object (File)
Sep 21 2024, 12:56 AM
Unknown Object (File)
Sep 18 2024, 10:17 PM
Unknown Object (File)
Sep 17 2024, 8:36 PM
View All 82 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rGb260e413b4b7: bhyve: read OpRegion address and size for GVT-d
rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d
Summary

The OpRegion provides some configuration bits and ACPI methods used by
some Intel drivers. The guest needs access to it. In the first step,
we're reading it's address and size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51469
Build 48360: arc lint + arc unit

Event Timeline

corvink created this revision.May 10 2023, 12:45 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 10 2023, 12:45 PM
corvink requested review of this revision.May 10 2023, 12:45 PM
Harbormaster completed remote builds in B51414: Diff 121796.May 10 2023, 12:45 PM
corvink added a child revision: D40041: bhyve: copy OpRegion into guest memory.May 10 2023, 12:51 PM
corvink added a parent revision: D40039: bhyve: read out graphics stolen memory address and size.
markj added inline comments.May 10 2023, 5:49 PM
usr.sbin/bhyve/pci_gvt-d.c
167

It can't be O_RDONLY?

200

memfd is leaked here, no? We should be able to close it after mapping the header, I believe. In general we don't want to leave a fd for /dev/mem lying around.

corvink updated this revision to Diff 121847.May 11 2023, 10:37 AM
  • don't leak memfd
  • open memfd readonly
Harbormaster completed remote builds in B51442: Diff 121847.May 11 2023, 10:38 AM
corvink added a parent revision: D40060: bhyve: emulate graphics stolen memory register.May 11 2023, 10:39 AM
corvink removed a parent revision: D40039: bhyve: read out graphics stolen memory address and size.
corvink added a parent revision: D40037: bhyve: import OpRegion definitions.May 11 2023, 12:32 PM
markj added inline comments.May 11 2023, 2:55 PM
usr.sbin/bhyve/pci_gvt-d.c
185
187
189

The header is guaranteed to be page-aligned?

corvink added inline comments.May 12 2023, 12:17 PM
usr.sbin/bhyve/pci_gvt-d.c
189

No, it doesn't have to be page aligned. On my systems it has an offset of +0x18 to page boundary. Don't know why.

corvink updated this revision to Diff 121907.May 12 2023, 12:24 PM
  • don't return errno
  • make use of warn instead of warnx
Harbormaster completed remote builds in B51469: Diff 121907.May 12 2023, 12:24 PM
corvink marked 4 inline comments as done.May 12 2023, 12:24 PM
corvink marked an inline comment as done.Jun 6 2023, 9:23 AM

@jhb @markj Any additional comments?

jhb accepted this revision.Jun 7 2023, 6:35 PM
This revision is now accepted and ready to land.Jun 7 2023, 6:35 PM
Closed by commit rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d (authored by corvink). · Explain WhyJun 16 2023, 6:15 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG6952b9d25e18: bhyve: read OpRegion address and size for GVT-d.
corvink added a commit: rGb260e413b4b7: bhyve: read OpRegion address and size for GVT-d.Aug 18 2023, 7:43 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
67 lines

Diff 121907

View Options

usr.sbin/bhyve/pci_gvt-d.c

Loading...