Page MenuHomeFreeBSD
Differential D40034

bhyve: don't panic if e820 finds no available memory
ClosedPublic
Actions

Authored by corvink on May 10 2023, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 10:38 PM
Unknown Object (File)
Tue, Sep 3, 8:58 PM
Unknown Object (File)
Sun, Sep 1, 11:15 AM
Unknown Object (File)
Sun, Sep 1, 11:15 AM
Unknown Object (File)
Sun, Sep 1, 11:15 AM
Unknown Object (File)
Sun, Sep 1, 11:15 AM
Unknown Object (File)
Wed, Aug 28, 1:59 AM
Unknown Object (File)
Aug 19 2024, 3:20 PM
View All 59 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG3152cbdd1657: bhyve: don't panic if e820 finds no available memory
rG99aeb28b2f7e: bhyve: don't panic if e820 finds no available memory
Summary

The GVT-d emulation tries to allocate some specific memory. It could
happen that this address doesn't exist. In that case, GVT-d will fall
back to allocate any address. Nevertheless, this only works if the e820
fails with an error instead of exiting on an assertion.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.May 10 2023, 12:45 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMay 10 2023, 12:45 PM
corvink requested review of this revision.May 10 2023, 12:45 PM
Harbormaster completed remote builds in B51408: Diff 121790.May 10 2023, 12:45 PM
corvink added a child revision: D40035: bhyve: make passthru sel public available.May 10 2023, 12:51 PM
markj added inline comments.May 10 2023, 1:43 PM
usr.sbin/bhyve/e820.c
199

Please add a comment describing the scenario where this happens.

corvink updated this revision to Diff 121841.May 11 2023, 10:34 AM
  • add comment to explain when adding an e820 entry is intended to fail
Harbormaster completed remote builds in B51436: Diff 121841.May 11 2023, 10:34 AM
corvink edited child revisions, added: D40059: bhyve: allocate guest memory for graphics stolen memory; removed: D40035: bhyve: make passthru sel public available.May 11 2023, 12:31 PM
markj accepted this revision as: markj.May 11 2023, 2:35 PM
This revision is now accepted and ready to land.May 11 2023, 2:35 PM
Closed by commit rG99aeb28b2f7e: bhyve: don't panic if e820 finds no available memory (authored by corvink). · Explain WhyMay 12 2023, 7:48 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG99aeb28b2f7e: bhyve: don't panic if e820 finds no available memory.
corvink added a commit: rG3152cbdd1657: bhyve: don't panic if e820 finds no available memory.Aug 17 2023, 1:03 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
16 lines

Diff 121894

View Options

usr.sbin/bhyve/e820.c

Loading...