Page MenuHomeFreeBSD

hwpmc: pass pmc pointer to more class methods
ClosedPublic

Authored by mhorne on May 1 2023, 7:40 PM.
Tags
None
Referenced Files
F98525705: D39915.diff
Thu, Oct 3, 5:25 PM
Unknown Object (File)
Wed, Sep 25, 8:18 PM
Unknown Object (File)
Wed, Sep 25, 6:09 AM
Unknown Object (File)
Wed, Sep 25, 1:24 AM
Unknown Object (File)
Sat, Sep 21, 2:08 AM
Unknown Object (File)
Fri, Sep 20, 1:18 PM
Unknown Object (File)
Sat, Sep 14, 9:20 AM
Unknown Object (File)
Thu, Sep 5, 5:02 PM

Details

Summary

In many cases this avoids an extra lookup, since the callers always have
pm at hand. We can also eliminate several assertions, mostly for pm !=
NULL. The class methods are an internal interface, and the callers
already handle such a scenario. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51290
Build 48181: arc lint + arc unit

Event Timeline

Tinderbox points out that I didn't finish the change for a few platforms.

Update other classes; it now passes tinderbox.

FYI, the pm_id field in a struct pmc contains the CPU and 'row index' for the PMC, so we could potentially drop the cpu and ri fields in a future change.

This revision is now accepted and ready to land.May 3 2023, 9:48 AM
This revision was automatically updated to reflect the committed changes.