Page MenuHomeFreeBSD
Differential D39910

hwpmc: don't use deprecated copystr(9)
ClosedPublic
Actions

Authored by mhorne on May 1 2023, 7:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 6:53 PM
Unknown Object (File)
Sat, Jan 18, 7:40 AM
Unknown Object (File)
Wed, Jan 15, 12:34 PM
Unknown Object (File)
Tue, Jan 14, 8:19 AM
Unknown Object (File)
Tue, Jan 14, 7:53 AM
Unknown Object (File)
Fri, Jan 10, 10:40 PM
Unknown Object (File)
Fri, Jan 10, 10:13 PM
Unknown Object (File)
Fri, Jan 10, 6:52 PM
View All 75 Files
Subscribers
andrew
emaste
imp
jrtc27

Details

Reviewers
jkoshy
gnn
Group Reviewers
pmc
Commits
rG67239b0a33b2: hwpmc: don't use deprecated copystr(9)
rG31610e34b7e3: hwpmc: don't use deprecated copystr(9)
Summary

It is just wrapper around strlcpy(), but results in more complicated
code. Clean this up to use strlcpy() or snprintf() as appropriate.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 51285
Build 48176: arc lint + arc unit

Event Timeline

mhorne created this revision.May 1 2023, 7:39 PM
Herald added a reviewer: gnn. · View Herald TranscriptMay 1 2023, 7:39 PM
Herald added subscribers: andrew, imp. · View Herald Transcript
mhorne requested review of this revision.May 1 2023, 7:39 PM
Harbormaster completed remote builds in B51285: Diff 121329.May 1 2023, 7:39 PM
mhorne added a parent revision: D39909: hwpmc: use kstack_contains().May 1 2023, 7:39 PM
mhorne added a child revision: D39911: hwpmc_logging: less macro magic for type names.
jkoshy requested changes to this revision.May 2 2023, 7:42 AM
jkoshy added inline comments.
sys/dev/hwpmc/hwpmc_amd.c
919

How about using sizeof(pi->pm_name) instead of PMC_NAME_MAX?

This would remove the need for the reader to check that the pm_name field is at least PMC_NAME_MAX in size.

Here and below.

This revision now requires changes to proceed.May 2 2023, 7:42 AM
mhorne updated this revision to Diff 121394.May 2 2023, 4:16 PM
mhorne marked an inline comment as done.

Use sizeof(pi->pm_name).

Harbormaster completed remote builds in B51315: Diff 121394.May 2 2023, 4:16 PM
jkoshy accepted this revision.May 2 2023, 5:58 PM

LGTM

This revision is now accepted and ready to land.May 2 2023, 5:58 PM
Closed by commit rG31610e34b7e3: hwpmc: don't use deprecated copystr(9) (authored by mhorne). · Explain WhyMay 6 2023, 5:51 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG31610e34b7e3: hwpmc: don't use deprecated copystr(9).
mhorne added a commit: rG67239b0a33b2: hwpmc: don't use deprecated copystr(9).Jun 9 2023, 7:58 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
7 lines
9 lines
9 lines
16 lines
11 lines
9 lines
7 lines
7 lines
16 lines

Diff 121329

View Options

sys/dev/hwpmc/hwpmc_amd.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_arm64.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_armv7.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_core.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_dmc620.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_powerpc.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_soft.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_tsc.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_uncore.c

Loading...