Page MenuHomeFreeBSD
Differential D39890

amd64: store pcids pmap data in pcpu zone
ClosedPublic
Actions

Authored by kib on May 1 2023, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 2:13 AM
Unknown Object (File)
Fri, Oct 25, 9:41 AM
Unknown Object (File)
Fri, Oct 25, 9:39 AM
Unknown Object (File)
Fri, Oct 25, 9:37 AM
Unknown Object (File)
Fri, Oct 25, 9:35 AM
Unknown Object (File)
Wed, Oct 16, 12:28 PM
Unknown Object (File)
Oct 7 2024, 11:41 AM
Unknown Object (File)
Oct 2 2024, 5:59 AM
View All 65 Files
Subscribers
emaste
imp
mjg

Details

Reviewers
alc
markj
Commits
rG42f722e721cd: amd64: store pcids pmap data in pcpu zone
rG9c8cbf381985: amd64 pmap_pcid_alloc(): pass a pointer to struct pmap_pcid instead of cpuid
rG9e0143694ad3: amd64: add pmap_get_pcid() helper
rG86b61ccb34d4: amd64 pmap: add pmap_pinit_pcids() helper
rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h
Summary

This boots multiuser on Ivy.
Per-patch view is available at https://kib.kiev.ua/git/gitweb.cgi?p=deviant3.git;a=shortlog;h=refs/heads/maxcpu2

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.May 1 2023, 11:53 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 1 2023, 11:53 AM
kib requested review of this revision.May 1 2023, 11:53 AM
markj added inline comments.May 1 2023, 1:59 PM
sys/amd64/amd64/pmap.c
2038

Or just (void *)(uintptr_t)offsetof(struct pcpu, pc_kpmap_store)?

sys/amd64/include/_pmap.h
1

Missing a license header.

4

Why "pcids" instead of "pcid"?

sys/amd64/include/pmap.h
542–543
kib marked 4 inline comments as done.May 1 2023, 2:48 PM
kib added inline comments.
sys/amd64/include/_pmap.h
4

I do not remember why did I named it with 's'. Included the rename into the series.

kib updated this revision to Diff 121300.May 1 2023, 2:49 PM
kib marked an inline comment as done.

Rename pmap_pcids to pmap_pcid.
Simplify kernel pmap pcpu pointer calculation.
Add license.

markj accepted this revision.May 1 2023, 3:11 PM
This revision is now accepted and ready to land.May 1 2023, 3:11 PM
alc added inline comments.May 1 2023, 4:34 PM
sys/amd64/amd64/pmap.c
388–389
kib marked an inline comment as done.May 2 2023, 1:16 AM
Closed by commit rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h (authored by kib). · Explain WhyMay 2 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG32bb28d8ad31: amd64: move definition of the struct pmap_pcids into _pmap.h.
kib added a commit: rG86b61ccb34d4: amd64 pmap: add pmap_pinit_pcids() helper.
kib added a commit: rG9e0143694ad3: amd64: add pmap_get_pcid() helper.
kib added a commit: rG9c8cbf381985: amd64 pmap_pcid_alloc(): pass a pointer to struct pmap_pcid instead of cpuid.
kib added a commit: rG42f722e721cd: amd64: store pcids pmap data in pcpu zone.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
19 lines
20 lines
120 lines
include/
9 lines
4 lines
19 lines

Diff 121283

View Options

sys/amd64/amd64/efirt_machdep.c

Loading...
View Options

sys/amd64/amd64/mp_machdep.c

Loading...
View Options

sys/amd64/amd64/pmap.c

Loading...
View Options

sys/amd64/include/_pmap.h

Loading...
View Options

sys/amd64/include/pcpu.h

Loading...
View Options

sys/amd64/include/pmap.h

Loading...