Page MenuHomeFreeBSD
Differential D39844

armv7: release: Stop installing BBB u-boot
ClosedPublic
Actions

Authored by manu on Apr 27 2023, 6:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 4:25 PM
Unknown Object (File)
Fri, Nov 1, 5:28 PM
Unknown Object (File)
Tue, Oct 29, 2:10 PM
Unknown Object (File)
Tue, Oct 29, 8:13 AM
Unknown Object (File)
Wed, Oct 23, 1:18 PM
Unknown Object (File)
Wed, Oct 23, 8:05 AM
Unknown Object (File)
Mon, Oct 21, 6:26 AM
Unknown Object (File)
Mon, Oct 21, 6:26 AM
View All 63 Files
Subscribers
andrew
emaste
gjb
imp
jrtc27
oskar.holmlund_ohdata.se

Details

Reviewers
imp
gjb
Group Reviewers
ARM
releng
Commits
rGea9075959bf3: armv7: release: Stop installing BBB u-boot
Summary

BBB code was removed from GENERIC kernel as it's not functional.
Stop installing u-boot for a platform that we don't boot on.

MFC after: never
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51256
Build 48147: arc lint + arc unit

Event Timeline

manu created this revision.Apr 27 2023, 6:23 AM
Herald added subscribers: jrtc27, andrew, imp. · View Herald TranscriptApr 27 2023, 6:23 AM
manu requested review of this revision.Apr 27 2023, 6:23 AM
Harbormaster completed remote builds in B51229: Diff 121121.Apr 27 2023, 6:23 AM
manu added reviewers: ARM, releng.Apr 27 2023, 6:23 AM
oskar.holmlund_ohdata.se added a subscriber: oskar.holmlund_ohdata.se.Apr 27 2023, 6:25 AM
emaste added a subscriber: emaste.Apr 27 2023, 3:15 PM
imp accepted this revision.Apr 27 2023, 5:50 PM

I hate to see it go... but on the other hand my hate isn't for it leaving, but that the support for it in -current has decayed too much

This revision is now accepted and ready to land.Apr 27 2023, 5:50 PM
gjb requested changes to this revision.Apr 27 2023, 6:02 PM
gjb added a subscriber: gjb.
gjb added inline comments.
release/arm/GENERICSD.conf
51–52

Why not just get rid of the arm_install_uboot_bbb() call here, and remove the function entirely? It is not used anywhere else.

This revision now requires changes to proceed.Apr 27 2023, 6:02 PM
manu added inline comments.Apr 27 2023, 7:25 PM
release/arm/GENERICSD.conf
51–52

Indeed, will do that tomorow.

gjb added inline comments.Apr 27 2023, 7:31 PM
release/arm/GENERICSD.conf
51–52

As part of this review?

manu added inline comments.Apr 28 2023, 5:21 AM
release/arm/GENERICSD.conf
51–52

Yes, it's better to remove everything BBB related in release/ in one commit. Also easier if someone wants to work on this platform to revert only 1 or 2 commits

manu updated this revision to Diff 121215.Apr 28 2023, 8:07 PM

Remove arm_install_uboot_bbb too

Harbormaster completed remote builds in B51256: Diff 121215.Apr 28 2023, 8:07 PM
manu marked 2 inline comments as done.Apr 28 2023, 8:07 PM
gjb accepted this revision.Apr 28 2023, 8:39 PM
This revision is now accepted and ready to land.Apr 28 2023, 8:39 PM
Closed by commit rGea9075959bf3: armv7: release: Stop installing BBB u-boot (authored by manu). · Explain WhyMay 1 2023, 6:33 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGea9075959bf3: armv7: release: Stop installing BBB u-boot.

Revision Contents
Changeset List

PathSize
release/
arm/
17 lines

Diff 121215

View Options

release/arm/GENERICSD.conf

Loading...