Paths

Table of Contentst

buf: Dynamically allocate per-CPU buffer queues
ClosedPublic
Actions

Authored by markj on Apr 25 2023, 5:22 PM.

Details

Reviewers

kib
mjg
jhb
emaste

Commits

rGaec3c884057a: buf: Dynamically allocate per-CPU buffer queues
rGe72f7ed43eef: buf: Dynamically allocate per-CPU buffer queues

Summary

To reduce static bloat. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 25 2023, 5:22 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2023, 5:22 PM

markj requested review of this revision.Apr 25 2023, 5:22 PM

Harbormaster completed remote builds in B51182: Diff 121015.Apr 25 2023, 5:22 PM

markj added a parent revision: D39807: callout: Move per-CPU callout state into the dpcpu region.Apr 25 2023, 5:22 PM

mjg accepted this revision.Apr 25 2023, 5:25 PM

This revision is now accepted and ready to land.Apr 25 2023, 5:25 PM

emaste accepted this revision.Apr 25 2023, 5:40 PM

emaste added inline comments.

sys/kern/vfs_bio.c
121	The comment should perhaps be moved to the allocation? It's really justifying the `+1` or `mp_maxid + 2` IMO?

kib accepted this revision.Apr 26 2023, 1:27 AM

kib added inline comments.

sys/kern/vfs_bio.c
121	No, it needs +2, since bd_subq[mp_maxid] is populated by maxid cpu queue.

emaste added inline comments.Apr 26 2023, 1:35 AM

sys/kern/vfs_bio.c
121	I just meant that the comment is explaining why it's `+1` (in main now) or `+2` (with mark's change) and should go at line 1917

Move the comment to the right place.

This revision now requires review to proceed.Apr 26 2023, 1:49 PM

Harbormaster completed remote builds in B51215: Diff 121085.Apr 26 2023, 1:49 PM

emaste accepted this revision.Apr 26 2023, 1:58 PM

This revision is now accepted and ready to land.Apr 26 2023, 1:58 PM

Closed by commit rGe72f7ed43eef: buf: Dynamically allocate per-CPU buffer queues (authored by markj). · Explain WhyApr 26 2023, 2:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGe72f7ed43eef: buf: Dynamically allocate per-CPU buffer queues.

markj added a commit: rGaec3c884057a: buf: Dynamically allocate per-CPU buffer queues.May 11 2023, 1:33 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_bio.c

5 lines

Diff 121091

View Options

buf: Dynamically allocate per-CPU buffer queuesClosedPublicActions