Page MenuHomeFreeBSD
Differential D39639

arm64: Use FULLKERNEL instead of .ALLSRC in .bin target
ClosedPublic
Actions

Authored by stevek on Apr 18 2023, 5:36 AM.
Tags
None
Referenced Files
F96760936: D39639.diff
Thu, Sep 26, 11:46 AM
Unknown Object (File)
Thu, Sep 26, 2:05 AM
Unknown Object (File)
Sun, Sep 22, 11:34 PM
Unknown Object (File)
Sun, Sep 22, 12:33 PM
Unknown Object (File)
Thu, Sep 19, 9:10 PM
Unknown Object (File)
Thu, Sep 19, 1:46 PM
Unknown Object (File)
Thu, Sep 19, 11:15 AM
Unknown Object (File)
Mon, Sep 16, 4:23 PM
View All 26 Files
Subscribers
andrew
emaste
imp
sjg

Details

Reviewers
andrew
emaste
Commits
rGfb5ff7384cfd: arm64: Use FULLKERNEL instead of .ALLSRC in .bin target
Summary

Using .ALLSRC may get additional arguments that we may not want
and could cause the objcopy to fail.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

stevek created this revision.Apr 18 2023, 5:36 AM
Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptApr 18 2023, 5:36 AM
stevek requested review of this revision.Apr 18 2023, 5:36 AM
Harbormaster completed remote builds in B50986: Diff 120535.Apr 18 2023, 5:36 AM
stevek added a reviewer: andrew.Apr 18 2023, 5:37 AM
emaste added a subscriber: sjg.Apr 18 2023, 12:12 PM
emaste added a comment.Apr 18 2023, 12:16 PM

IMO this is fine, but also ${.ALLSRC} should only ever be ${FULLKERNEL} so not sure how you'd get this case.

stevek added a comment.Apr 18 2023, 1:54 PM
In D39639#902347, @emaste wrote:

IMO this is fine, but also ${.ALLSRC} should only ever be ${FULLKERNEL} so not sure how you'd get this case.

In downstream build environments, there could be additional dependencies added.

The ${NM} statement should probably also use ${FULLKERNEL}, since that is what we really want to operate on.

emaste accepted this revision.Apr 18 2023, 2:19 PM

In downstream build environments, there could be additional dependencies added.

Ok, fair enough. It could maybe be something like ${.ALLSRC:[1]} instead but I'm fine with it either way

This revision is now accepted and ready to land.Apr 18 2023, 2:19 PM
Closed by commit rGfb5ff7384cfd: arm64: Use FULLKERNEL instead of .ALLSRC in .bin target (authored by stevek). · Explain WhyApr 18 2023, 3:43 PM
This revision was automatically updated to reflect the committed changes.
stevek added a commit: rGfb5ff7384cfd: arm64: Use FULLKERNEL instead of .ALLSRC in .bin target.

Revision Contents
Changeset List

PathSize
sys/
conf/
4 lines

Diff 120572

View Options

sys/conf/Makefile.arm64

Loading...