libc: unsplit log message to to make it greppable in src
ClosedPublic
Actions

Authored by emaste on Apr 17 2023, 4:01 PM.

Details

Reviewers

dim
zlei

Commits

rGdedc71fd3890: libc: unsplit log message to to make it greppable in src

Summary

Also use func rather than hardcoding the function name. This code now fits in 80 columns without splitting the log message.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Apr 17 2023, 4:01 PM

emaste created this revision.

zlei added a subscriber: zlei.Apr 21 2023, 5:01 PM

zlei added inline comments.

lib/libc/stdlib/cxa_thread_atexit_impl.c
113	Will `__func__` be expanded to `__cxa_thread_call_dtors` ?

dim added inline comments.Apr 21 2023, 6:28 PM

lib/libc/stdlib/cxa_thread_atexit_impl.c
113	Nope, `__func__` is always the name of the enclosing function, in this case `walk_cb_call`. @emaste maybe this will confuse people?

Ok, __cxa_thread_call_dtors is more useful for tracking this down so restore explicit function name (and just accept > 80 cols)

upload diff relative to main, not the fixup change

Looks good to me.

This revision is now accepted and ready to land.Apr 23 2023, 1:16 AM

Closed by commit rGdedc71fd3890: libc: unsplit log message to to make it greppable in src (authored by emaste). · Explain WhyAug 5 2023, 1:01 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdedc71fd3890: libc: unsplit log message to to make it greppable in src.

Herald added a subscriber: imp. · View Herald TranscriptAug 5 2023, 1:01 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdlib/

cxa_thread_atexit_impl.c

4 lines

Diff 120479

View Options

lib/libc/stdlib/cxa_thread_atexit_impl.c

libc: unsplit log message to to make it greppable in srcClosedPublicActions