Page MenuHomeFreeBSD

DEBUG_VFS_LOCKS: use witness if available
ClosedPublic

Authored by kib on Apr 8 2023, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:49 AM
Unknown Object (File)
Thu, Oct 24, 4:47 PM
Unknown Object (File)
Tue, Oct 22, 8:28 PM
Unknown Object (File)
Oct 9 2024, 1:01 AM
Unknown Object (File)
Oct 7 2024, 7:14 AM
Unknown Object (File)
Oct 5 2024, 12:16 AM
Unknown Object (File)
Oct 2 2024, 2:37 AM
Unknown Object (File)
Oct 1 2024, 4:21 PM
Subscribers

Details

Summary

The assert_vop_locked messages are ignored, and file/line information is not too useful. Fixing this without changing both witness and VFS asserts KPIs is not possible.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Apr 8 2023, 6:18 AM
markj added inline comments.
sys/kern/vfs_subr.c
5466

Now, the witness version will fail if the lock is disowned (i.e., owner is LK_KERNPROC), but the other version will pass. It doesn't matter at the moment since vnode locks are never disowned AFAIK.

This revision is now accepted and ready to land.Apr 8 2023, 8:36 PM
kib marked an inline comment as done.Apr 9 2023, 12:36 AM
kib added inline comments.
sys/kern/vfs_subr.c
5466

LK_KERNPROC is only used for buffers. I do not see any need to introduce its use for vnodes.

This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.