Page MenuHomeFreeBSD
Differential D39406

mlx5ib(4): Mark driver knows net epoch
ClosedPublic
Actions

Authored by zlei on Apr 4 2023, 4:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 8:05 PM
Unknown Object (File)
Oct 16 2024, 1:01 PM
Unknown Object (File)
Oct 16 2024, 11:57 AM
Unknown Object (File)
Oct 16 2024, 11:56 AM
Unknown Object (File)
Oct 2 2024, 6:38 PM
Unknown Object (File)
Sep 24 2024, 7:24 PM
Unknown Object (File)
Sep 24 2024, 4:58 PM
Unknown Object (File)
Sep 24 2024, 1:27 AM
View All 40 Files
Subscribers
ae
imp

Details

Reviewers
• hselasky
kib
Group Reviewers
network
Commits
rGa023d986e462: mlx5ib(4): Mark driver knows net epoch
rGda4068c4e1a0: mlx5ib(4): Mark driver knows net epoch
Summary

The driver has already been EPOCH(9) aware since e48813009c6a.

Tested by: hselasky
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Apr 4 2023, 4:13 PM
Herald added subscribers: ae, imp. · View Herald TranscriptApr 4 2023, 4:13 PM
zlei requested review of this revision.Apr 4 2023, 4:13 PM
zlei added a reviewer: network.
zlei added a parent revision: D39405: infiniband: Opt-in for net epoch.Apr 4 2023, 4:16 PM
zlei edited the summary of this revision. (Show Details)Apr 4 2023, 4:23 PM
zlei edited the summary of this revision. (Show Details)
• hselasky accepted this revision.Apr 4 2023, 4:24 PM

The mlx5 core IRQ handler grabs the NET EPOCH for all CQEs, so this should be pretty much fine!

Adding Konstantin just in case!

This revision is now accepted and ready to land.Apr 4 2023, 4:24 PM
• hselasky added a reviewer: kib.Apr 4 2023, 4:25 PM
kib added a comment.Apr 4 2023, 11:35 PM

I am unable to find the definition of the IB_DEVICE_KNOWSEPOCH symbol in the FreeBSD sources.

zlei added a comment.Apr 5 2023, 1:19 AM
In D39406#897329, @kib wrote:

I am unable to find the definition of the IB_DEVICE_KNOWSEPOCH symbol in the FreeBSD sources.

That depends on D39405 which has not been committed.

Closed by commit rGda4068c4e1a0: mlx5ib(4): Mark driver knows net epoch (authored by zlei). · Explain WhyApr 5 2023, 4:10 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rGda4068c4e1a0: mlx5ib(4): Mark driver knows net epoch.
zlei added a comment.Apr 5 2023, 4:13 PM

@kib
I committed this quickly, I assume you will approve this change.

• hselasky added a comment.Apr 5 2023, 4:17 PM

@kib : I will sync these changes internally ...

zlei added a commit: rGa023d986e462: mlx5ib(4): Mark driver knows net epoch.Apr 21 2023, 10:11 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx5/
mlx5_ib/
3 lines

Diff 119904

View Options

sys/dev/mlx5/mlx5_ib/mlx5_ib_main.c

Loading...