Page MenuHomeFreeBSD

arm64/disassem.c: Add support str/strb/strh instructions
ClosedPublic

Authored by koliagogsadze_gmail.com on Mar 29 2023, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 7:03 PM
Unknown Object (File)
Mon, Sep 23, 6:57 PM
Unknown Object (File)
Mon, Sep 23, 12:21 PM
Unknown Object (File)
Mon, Sep 23, 9:37 AM
Unknown Object (File)
Sun, Sep 22, 8:35 AM
Unknown Object (File)
Fri, Sep 20, 12:36 PM
Unknown Object (File)
Fri, Sep 20, 9:43 AM
Unknown Object (File)
Thu, Sep 19, 5:32 PM
Subscribers

Details

Summary

Added dissassembly support for all types str/strb/strh instruction enconding.

Test Plan

Tested all possible combinations, test branch where I manually
tested my changes:
https://github.com/freebsd/freebsd-src/compare/main...toor1245:freebsd-src:arm64-disasm-str-test

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50671
Build 47562: arc lint + arc unit

Event Timeline

Looks good to me, thanks for linking the documentation!

sys/arm64/arm64/disassem.c
188

The only thing I'm unsure about is the OP_SF32. It's exact purpose is not so clear to me but I trust it's correct based on ldrb/ldrh and your testing.

This revision is now accepted and ready to land.Apr 14 2023, 6:14 PM