bhyve: allow device specific DSDT entries
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 1:25 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG1c7053169d9d: bhyve: allow device specific DSDT entries
rGe976464a50ac: bhyve: allow device specific DSDT entries

Summary

This feature will be used by future commits to implement a device
specific method (_DSM) for TPM devices.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50767
Build 47658: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 29 2023, 1:25 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 1:25 PM

corvink requested review of this revision.Mar 29 2023, 1:25 PM

Harbormaster completed remote builds in B50651: Diff 119610.Mar 29 2023, 1:25 PM

corvink added a child revision: D39322: bhyve: save softc of ACPI devices.Mar 29 2023, 1:25 PM

corvink added a parent revision: D39320: bhyve: allow building device specific ACPI tables.

markj added inline comments.Apr 3 2023, 6:08 PM

usr.sbin/bhyve/acpi_device.c
196	The return value is ignored?

don't ignore the return value of write_dsdt

Harbormaster completed remote builds in B50767: Diff 119871.Apr 5 2023, 7:01 AM

corvink edited parent revisions, added: D39422: bhyve: check for errors when writing device specific DSDT entries; removed: D39320: bhyve: allow building device specific ACPI tables.Apr 5 2023, 7:02 AM

markj accepted this revision as: markj.Apr 10 2023, 2:35 PM

This revision is now accepted and ready to land.Apr 10 2023, 2:35 PM

Closed by commit rGe976464a50ac: bhyve: allow device specific DSDT entries (authored by corvink). · Explain WhyApr 12 2023, 7:05 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGe976464a50ac: bhyve: allow device specific DSDT entries.

corvink added a commit: rG1c7053169d9d: bhyve: allow device specific DSDT entries.Apr 28 2023, 10:41 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

acpi_device.h

1 line

acpi_device.c

5 lines

Diff 119871

View Options

usr.sbin/bhyve/acpi_device.h