bhyve: allow building device specific ACPI tables
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 1:24 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG76f744cf2d08: bhyve: allow building device specific ACPI tables
rG0926566f6f9c: bhyve: allow building device specific ACPI tables

Summary

Some ACPI devices require a device specific acpi table. E.g. a TPM2
device requires a TPM2 table. Use the acpi_device_emul struct to define
such a device specific table.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Mar 29 2023, 1:24 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 1:24 PM

corvink requested review of this revision.Mar 29 2023, 1:24 PM

Harbormaster completed remote builds in B50650: Diff 119609.Mar 29 2023, 1:24 PM

corvink added a child revision: D39321: bhyve: allow device specific DSDT entries.Mar 29 2023, 1:25 PM

corvink added a parent revision: D39319: bhyve: introduce acpi_device_emul struct.

corvink mentioned this in D39319: bhyve: introduce acpi_device_emul struct.Mar 31 2023, 8:19 AM

make use of assert

Harbormaster completed remote builds in B50765: Diff 119869.Apr 5 2023, 7:01 AM

corvink removed a child revision: D39321: bhyve: allow device specific DSDT entries.Apr 5 2023, 7:02 AM

corvink added a child revision: D39422: bhyve: check for errors when writing device specific DSDT entries.

markj added inline comments.Apr 10 2023, 2:34 PM

usr.sbin/bhyve/acpi_device.c
143	This can be an assertion.
usr.sbin/bhyve/acpi_device.h
31	The name `build_table` is quite general, so some comment should explain what this callback is for.