Page MenuHomeFreeBSD
Differential D39320

bhyve: allow building device specific ACPI tables
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 1:24 PM.
Tags
None
Referenced Files
F102032788: D39320.diff
Wed, Nov 6, 6:30 PM
Unknown Object (File)
Sat, Oct 26, 12:41 PM
Unknown Object (File)
Mon, Oct 21, 1:27 PM
Unknown Object (File)
Wed, Oct 9, 1:47 AM
Unknown Object (File)
Wed, Oct 9, 1:47 AM
Unknown Object (File)
Wed, Oct 9, 1:46 AM
Unknown Object (File)
Wed, Oct 9, 1:45 AM
Unknown Object (File)
Wed, Oct 9, 1:20 AM
View All 96 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rG76f744cf2d08: bhyve: allow building device specific ACPI tables
rG0926566f6f9c: bhyve: allow building device specific ACPI tables
Summary

Some ACPI devices require a device specific acpi table. E.g. a TPM2
device requires a TPM2 table. Use the acpi_device_emul struct to define
such a device specific table.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50765
Build 47656: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 29 2023, 1:24 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 1:24 PM
corvink requested review of this revision.Mar 29 2023, 1:24 PM
Harbormaster completed remote builds in B50650: Diff 119609.Mar 29 2023, 1:24 PM
corvink added a child revision: D39321: bhyve: allow device specific DSDT entries.Mar 29 2023, 1:25 PM
corvink added a parent revision: D39319: bhyve: introduce acpi_device_emul struct.
corvink mentioned this in D39319: bhyve: introduce acpi_device_emul struct.Mar 31 2023, 8:19 AM
corvink updated this revision to Diff 119869.Apr 5 2023, 7:01 AM
  • make use of assert
Harbormaster completed remote builds in B50765: Diff 119869.Apr 5 2023, 7:01 AM
corvink removed a child revision: D39321: bhyve: allow device specific DSDT entries.Apr 5 2023, 7:02 AM
corvink added a child revision: D39422: bhyve: check for errors when writing device specific DSDT entries.
markj added inline comments.Apr 10 2023, 2:34 PM
usr.sbin/bhyve/acpi_device.c
143

This can be an assertion.

usr.sbin/bhyve/acpi_device.h
23

The name build_table is quite general, so some comment should explain what this callback is for.

corvink updated this revision to Diff 120132.Apr 11 2023, 6:54 AM
  • add comment to explain the usage of acpi_device_emul.build_table
Harbormaster completed remote builds in B50830: Diff 120132.Apr 11 2023, 6:55 AM
corvink marked 2 inline comments as done.Apr 11 2023, 6:55 AM
corvink added inline comments.
usr.sbin/bhyve/acpi_device.c
143

No, it can't. A build_table callback isn't used by all acpi_devices. F.e. qemu_fwcfg has no such callback.

markj accepted this revision as: markj.Apr 11 2023, 2:18 PM
markj added inline comments.
usr.sbin/bhyve/acpi.c
814
This revision is now accepted and ready to land.Apr 11 2023, 2:18 PM
Closed by commit rG0926566f6f9c: bhyve: allow building device specific ACPI tables (authored by corvink). · Explain WhyApr 12 2023, 7:05 AM
This revision was automatically updated to reflect the committed changes.
corvink marked an inline comment as done.
corvink added a commit: rG0926566f6f9c: bhyve: allow building device specific ACPI tables.
corvink added a commit: rG76f744cf2d08: bhyve: allow building device specific ACPI tables.Apr 28 2023, 10:41 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines
3 lines
12 lines

Diff 119869

View Options

usr.sbin/bhyve/acpi.c

Loading...
View Options

usr.sbin/bhyve/acpi_device.h

Loading...
View Options

usr.sbin/bhyve/acpi_device.c

Loading...