bhyve/fwcfg: add QEMU_FWCFG_INDEX_NB_CPUS item
ClosedPublic
Actions

Authored by corvink on Mar 29 2023, 12:44 PM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rGb0efaef285d6: bhyve: add QEMU_FWCFG_INDEX_NB_CPUS item
rGe46be58cca6b: bhyve: add QEMU_FWCFG_INDEX_NB_CPUS item

Summary

Requested-by: OVMF (qemu)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50647
Build 47538: arc lint + arc unit

Event Timeline

corvink created this revision.Mar 29 2023, 12:44 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMar 29 2023, 12:44 PM

corvink requested review of this revision.Mar 29 2023, 12:44 PM

Harbormaster completed remote builds in B50647: Diff 119605.Mar 29 2023, 12:44 PM

the comments from D39315 apply to this review as well

fix suggested style issues

Harbormaster completed remote builds in B50674: Diff 119656.Mar 30 2023, 5:56 AM

markj accepted this revision as: markj.Apr 3 2023, 6:17 PM

This revision is now accepted and ready to land.Apr 3 2023, 6:17 PM

Closed by commit rGe46be58cca6b: bhyve: add QEMU_FWCFG_INDEX_NB_CPUS item (authored by corvink). · Explain WhyApr 4 2023, 8:26 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGe46be58cca6b: bhyve: add QEMU_FWCFG_INDEX_NB_CPUS item.

Now that this is committed, I see (empirically) that the identifier "guest_ncpus" (src/usr.sbin/bhyve/qemu_fwcfg.c:237) is undeclared.

Should be fixed by https://cgit.FreeBSD.org/src/commit/?id=76fa62b5232e67ef10476cf1329aaceb9cbc2ff5

corvink added a commit: rGb0efaef285d6: bhyve: add QEMU_FWCFG_INDEX_NB_CPUS item.Apr 11 2023, 7:32 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

qemu_fwcfg.c

20 lines

Diff 119605

View Options

usr.sbin/bhyve/qemu_fwcfg.c

bhyve/fwcfg: add QEMU_FWCFG_INDEX_NB_CPUS itemClosedPublicActions