HomeFreeBSD
Diffusion FreeBSD src repository 643336549081

If copy_file_range(2) fails with EXDEV, use fall-back.
643336549081
Actions

Description

If copy_file_range(2) fails with EXDEV, use fall-back.

Details

Provenance
phkAuthored on Apr 4 2023, 7:39 AM
Parents
rG396b6914c91f: Fix pcie phy enabling codes for RK3568 SoC.
Branches
Unknown
Tags
Unknown
Reverted By
rGc5b5f2d8086f: cp: Revert "If copy_file_range(2) fails with EXDEV, use fall-back."

Event Timeline

phk committed rG643336549081: If copy_file_range(2) fails with EXDEV, use fall-back. (authored by phk).Apr 4 2023, 7:39 AM
mjg added a reverting change: rGc5b5f2d8086f: cp: Revert "If copy_file_range(2) fails with EXDEV, use fall-back.".Apr 24 2023, 4:07 PM
phk added a comment.Apr 24 2023, 5:24 PM

I personally find cp(1) far too important to let it fail sporadically.

I would prefer we always fall back, no matter what the errno, but be "fprintf(stderr, ..." noisy about unexpected errno's so that bugs get discovered.

Changes (1)

PathSize
bin/
cp/

rG643336549081

View Options

bin/cp/utils.c

Loading...