libc: Use secure_getenv(3) where appropriate
ClosedPublic
Actions

Authored by markj on Mar 26 2023, 4:51 PM.

Details

Reviewers

imp
mjg
kib

Commits

rG68ca8363c7a1: libc: Use secure_getenv(3) where appropriate

Summary

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Mar 26 2023, 4:51 PM

markj created this revision.

Harbormaster completed remote builds in B50594: Diff 119483.Mar 26 2023, 4:51 PM

mjg accepted this revision.Mar 26 2023, 5:46 PM

This revision is now accepted and ready to land.Mar 26 2023, 5:46 PM

kib accepted this revision.Mar 26 2023, 6:39 PM

guest-patmaddox added a subscriber: guest-patmaddox.Mar 26 2023, 6:47 PM

Did you use coccinelle (sp?) to find all these?

In D39278#894202, @imp wrote:

Did you use coccinelle (sp?) to find all these?

No, just cscope. I think it'd be tricky to write a coccinelle script for this since there's quite a few syntactic variations to look for. Maybe it's easier than I think though, I've only written a couple of scripts with it.

Closed by commit rG68ca8363c7a1: libc: Use secure_getenv(3) where appropriate (authored by markj). · Explain WhyMar 27 2023, 12:56 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG68ca8363c7a1: libc: Use secure_getenv(3) where appropriate.

Cross-builds on GitHub are failing for macOS, as secure_getenv() does not exist. Should I add it to tools/build/cross-build/include/mac/stdlib.h?

In D39278#894650, @jlduran_gmail.com wrote:

Cross-builds on GitHub are failing for macOS, as secure_getenv() does not exist. Should I add it to tools/build/cross-build/include/mac/stdlib.h?

Oops, thanks for the report. I suspect that'd be sufficient, yes. I started a CI run with that change and will push it if the build completes.

In D39278#894759, @markj wrote:

In D39278#894650, @jlduran_gmail.com wrote:

Cross-builds on GitHub are failing for macOS, as secure_getenv() does not exist. Should I add it to tools/build/cross-build/include/mac/stdlib.h?

Oops, thanks for the report. I suspect that'd be sufficient, yes. I started a CI run with that change and will push it if the build completes.