Page MenuHomeFreeBSD

kern_reboot(9): some updates
ClosedPublic

Authored by mhorne on Mar 16 2023, 7:36 PM.
Tags
None
Referenced Files
F102650931: D39133.diff
Fri, Nov 15, 8:44 AM
F102583761: D39133.diff
Thu, Nov 14, 9:27 AM
Unknown Object (File)
Fri, Nov 8, 4:50 AM
Unknown Object (File)
Mon, Oct 21, 2:20 PM
Unknown Object (File)
Mon, Oct 21, 1:09 PM
Unknown Object (File)
Thu, Oct 17, 5:32 PM
Unknown Object (File)
Oct 15 2024, 8:40 PM
Unknown Object (File)
Oct 14 2024, 9:34 PM

Details

Summary
  • This function no longer disables interrupts
  • MLINK to reboot.9
  • Document rebooting variable
  • The mentions of autoconfiguration is more about shutdown_nice(), coming in the next commit.
  • Describe the RB_* flags relevant to this function
  • Describe behaviour when shutdown hooks fail the reset
  • Describe expected execution contexts
  • Add FF copyright
  • xref panic(9)
  • xref this page in reboot(2)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50482
Build 47373: arc lint + arc unit

Event Timeline

share/man/man9/kern_reboot.9
104

The tense is inconsistent in several of the points below as well.

Make the verb tense consistent in the list of actions.

Minor nits, fixable on commit if nothing else stands out.

share/man/man9/kern_reboot.9
49
65
mhorne marked 3 inline comments as done.

Handle nits.

This revision is now accepted and ready to land.Mar 20 2023, 4:22 PM
rpokala added inline comments.
share/man/man9/kern_reboot.9
72

Might want to define what "Halt the system in-place" means.

100

The existing wording -- if a NO flag is not set -- is not very clear. Perhaps something like this instead:

Unless the
.Dv RB_NOSYNC
flag is set in
.Fa howto ,
sync and unmount the system's disks by calling
.Xr vfs_unmountall 9 .
114
is not set
128

s/unusual/unlikely/

This revision was automatically updated to reflect the committed changes.
mhorne marked 4 inline comments as done.