Page MenuHomeFreeBSD
Differential D39133

kern_reboot(9): some updates
ClosedPublic
Actions

Authored by mhorne on Mar 16 2023, 7:36 PM.
Tags
None
Referenced Files
F102583761: D39133.diff
Thu, Nov 14, 9:27 AM
Unknown Object (File)
Fri, Nov 8, 4:50 AM
Unknown Object (File)
Mon, Oct 21, 2:20 PM
Unknown Object (File)
Mon, Oct 21, 1:09 PM
Unknown Object (File)
Thu, Oct 17, 5:32 PM
Unknown Object (File)
Oct 15 2024, 8:40 PM
Unknown Object (File)
Oct 14 2024, 9:34 PM
Unknown Object (File)
Oct 14 2024, 9:34 PM
View All 80 Files
Subscribers
imp
pauamma_gundo.com
rpokala

Details

Reviewers
markj
imp
Group Reviewers
manpages
Commits
rGd55c1877386f: kern_reboot(9): some updates
Summary
  • This function no longer disables interrupts
  • MLINK to reboot.9
  • Document rebooting variable
  • The mentions of autoconfiguration is more about shutdown_nice(), coming in the next commit.
  • Describe the RB_* flags relevant to this function
  • Describe behaviour when shutdown hooks fail the reset
  • Describe expected execution contexts
  • Add FF copyright
  • xref panic(9)
  • xref this page in reboot(2)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50426
Build 47317: arc lint + arc unit

Event Timeline

mhorne created this revision.Mar 16 2023, 7:36 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 16 2023, 7:36 PM
mhorne requested review of this revision.Mar 16 2023, 7:36 PM
Harbormaster completed remote builds in B50426: Diff 118948.Mar 16 2023, 7:36 PM
mhorne added a parent revision: D39132: panic(9): some updates.Mar 16 2023, 7:36 PM
mhorne added a child revision: D39134: kern_reboot(9): document shutdown_nice().
mhorne added reviewers: markj, imp.Mar 16 2023, 7:40 PM
markj added inline comments.Mar 16 2023, 7:56 PM
share/man/man9/kern_reboot.9
103

The tense is inconsistent in several of the points below as well.

mhorne updated this revision to Diff 118959.Mar 16 2023, 9:41 PM

Make the verb tense consistent in the list of actions.

Harbormaster completed remote builds in B50436: Diff 118959.Mar 16 2023, 9:41 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 19 2023, 7:39 PM

Minor nits, fixable on commit if nothing else stands out.

share/man/man9/kern_reboot.9
49
65
mhorne updated this revision to Diff 119128.Mar 20 2023, 2:19 PM
mhorne marked 3 inline comments as done.

Handle nits.

Harbormaster completed remote builds in B50482: Diff 119128.Mar 20 2023, 2:19 PM
markj accepted this revision.Mar 20 2023, 4:22 PM
This revision is now accepted and ready to land.Mar 20 2023, 4:22 PM
rpokala added a subscriber: rpokala.Mar 20 2023, 4:55 PM
rpokala added inline comments.
share/man/man9/kern_reboot.9
72

Might want to define what "Halt the system in-place" means.

100

The existing wording -- if a NO flag is not set -- is not very clear. Perhaps something like this instead:

Unless the
.Dv RB_NOSYNC
flag is set in
.Fa howto ,
sync and unmount the system's disks by calling
.Xr vfs_unmountall 9 .
112–113
is not set
125

s/unusual/unlikely/

Closed by commit rGd55c1877386f: kern_reboot(9): some updates (authored by mhorne). · Explain WhyMar 20 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.
mhorne marked 4 inline comments as done.
mhorne added a commit: rGd55c1877386f: kern_reboot(9): some updates.

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
3 lines
share/
man/
man9/
1 line
100 lines

Diff 118948

View Options

lib/libc/sys/reboot.2

Loading...
View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/kern_reboot.9

Loading...