Page MenuHomeFreeBSD
Differential D39072

Add new DISK_IMAGE_TOOLS_BOOTSTRAP option
ClosedPublic
Actions

Authored by jrtc27 on Mar 13 2023, 10:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 6:06 AM
Unknown Object (File)
Fri, Jan 17, 11:03 AM
Unknown Object (File)
Sun, Jan 12, 7:55 PM
Unknown Object (File)
Fri, Jan 10, 10:17 AM
Unknown Object (File)
Dec 15 2024, 2:58 PM
Unknown Object (File)
Dec 11 2024, 3:27 PM
Unknown Object (File)
Nov 23 2024, 3:00 AM
Unknown Object (File)
Nov 23 2024, 3:00 AM
View All 51 Files
Subscribers
bdrewery

Details

Reviewers
imp
emaste
arichardson
Commits
rG9e914c7af1f3: Add new DISK_IMAGE_TOOLS_BOOTSTRAP option
Summary

This will build etdump, makefs and mkimg as bootstrap tools to allow
easily creating disk images. Note that etdump is bootstrapped due to its
use in the release scripts for building ISO images.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 50348
Build 47240: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Mar 13 2023, 10:47 PM
Herald added a subscriber: bdrewery. · View Herald TranscriptMar 13 2023, 10:47 PM
jrtc27 requested review of this revision.Mar 13 2023, 10:47 PM
Harbormaster completed remote builds in B50346: Diff 118775.Mar 13 2023, 10:47 PM
jrtc27 updated this revision to Diff 118777.Mar 13 2023, 10:51 PM

libnetbsd is internal; bootstrap even on FreeBSD

Harbormaster completed remote builds in B50348: Diff 118777.Mar 13 2023, 10:51 PM
jrtc27 added a child revision: D39073: .github: Test DISK_IMAGE_TOOLS_BOOTSTRAP in CI.Mar 13 2023, 10:51 PM
arichardson accepted this revision.Mar 13 2023, 11:29 PM

Not tested it but changes LGTM. Looking forward to dropping the workaround from cheribuild

This revision is now accepted and ready to land.Mar 13 2023, 11:29 PM
arichardson added inline comments.Mar 13 2023, 11:31 PM
share/mk/src.opts.mk
200

I do wonder if we want to just do this by default since it's only a few extra files being compiled.

emaste accepted this revision.Mar 14 2023, 1:43 AM

LGTM. I agree it'd be reasonable to include them always, they're pretty small.

jrtc27 added a parent revision: D39071: src.conf.5: Regen after ZFS-related options changes.Mar 14 2023, 1:46 AM
In D39072#889407, @emaste wrote:

LGTM. I agree it'd be reasonable to include them always, they're pretty small.

Could do, though I'm sure someone would complain that their native buildworld got slightly slower for no good reason...

Closed by commit rG9e914c7af1f3: Add new DISK_IMAGE_TOOLS_BOOTSTRAP option (authored by jrtc27). · Explain WhyMar 15 2023, 12:07 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG9e914c7af1f3: Add new DISK_IMAGE_TOOLS_BOOTSTRAP option.

Revision Contents
Changeset List

PathSize
22 lines
share/
man/
man5/
mk/
1 line
tools/
build/
options/
6 lines

Diff 118777

View Options

Makefile.inc1

Loading...
View Options

share/man/man5/src.conf.5

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

tools/build/options/WITH_DISK_IMAGE_TOOLS_BOOTSTRAP

Loading...