Page MenuHomeFreeBSD

make showconfig: set MACHINE appropriately
ClosedPublic

Authored by emaste on Mar 6 2023, 4:00 PM.
Tags
None
Referenced Files
F115415965: D38926.diff
Wed, Apr 23, 2:10 PM
Unknown Object (File)
Sat, Apr 19, 1:59 PM
Unknown Object (File)
Fri, Apr 11, 7:42 PM
Unknown Object (File)
Mar 15 2025, 11:21 PM
Unknown Object (File)
Mar 5 2025, 4:19 PM
Unknown Object (File)
Mar 2 2025, 7:17 AM
Unknown Object (File)
Mar 2 2025, 6:34 AM
Unknown Object (File)
Feb 19 2025, 1:30 AM
Subscribers
None

Details

Summary
Previously MACHINE was not set for the showconfig target, and was the
host's value rather than the target.  As a result some machine-dependent
kernel options were not reported with correct defaults in the src.conf
manpage.

PR: 269994
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Mar 6 2023, 4:00 PM
emaste created this revision.
emaste added inline comments.
Makefile.inc1
3393

Perhaps MACHINE_ARCH=${TARGET_ARCH} too? I notice builddtb below sets only MACHINE.

Don't see that MACHINE_ARCH is used, but it's always a good idea to set MACHINE and MACHINE_ARCH in pairs.

This revision is now accepted and ready to land.Mar 6 2023, 8:36 PM
This revision was automatically updated to reflect the committed changes.