Page MenuHomeFreeBSD

make showconfig: set MACHINE appropriately
ClosedPublic

Authored by emaste on Mar 6 2023, 4:00 PM.
Tags
None
Referenced Files
F110125076: D38926.diff
Thu, Feb 13, 11:09 PM
Unknown Object (File)
Wed, Jan 22, 12:57 AM
Unknown Object (File)
Tue, Jan 21, 1:00 PM
Unknown Object (File)
Mon, Jan 20, 11:20 AM
Unknown Object (File)
Fri, Jan 17, 5:17 PM
Unknown Object (File)
Jan 13 2025, 9:59 PM
Unknown Object (File)
Dec 2 2024, 5:51 PM
Unknown Object (File)
Oct 30 2024, 7:15 AM
Subscribers
None

Details

Summary
Previously MACHINE was not set for the showconfig target, and was the
host's value rather than the target.  As a result some machine-dependent
kernel options were not reported with correct defaults in the src.conf
manpage.

PR: 269994
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 6 2023, 4:00 PM
emaste created this revision.
emaste added inline comments.
Makefile.inc1
3380

Perhaps MACHINE_ARCH=${TARGET_ARCH} too? I notice builddtb below sets only MACHINE.

Don't see that MACHINE_ARCH is used, but it's always a good idea to set MACHINE and MACHINE_ARCH in pairs.

This revision is now accepted and ready to land.Mar 6 2023, 8:36 PM
This revision was automatically updated to reflect the committed changes.