Page MenuHomeFreeBSD

make showconfig: set MACHINE appropriately
ClosedPublic

Authored by emaste on Mar 6 2023, 4:00 PM.
Tags
None
Referenced Files
F97766077: D38926.diff
Tue, Oct 1, 4:29 AM
Unknown Object (File)
Sun, Sep 29, 7:11 AM
Unknown Object (File)
Thu, Sep 26, 6:11 AM
Unknown Object (File)
Wed, Sep 25, 3:02 AM
Unknown Object (File)
Tue, Sep 24, 1:47 AM
Unknown Object (File)
Fri, Sep 20, 12:33 AM
Unknown Object (File)
Thu, Sep 19, 5:29 PM
Unknown Object (File)
Tue, Sep 17, 6:55 AM
Subscribers
None

Details

Summary
Previously MACHINE was not set for the showconfig target, and was the
host's value rather than the target.  As a result some machine-dependent
kernel options were not reported with correct defaults in the src.conf
manpage.

PR: 269994
Sponsored by: The FreeBSD Foundation

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 6 2023, 4:00 PM
emaste created this revision.
emaste added inline comments.
Makefile.inc1
3380

Perhaps MACHINE_ARCH=${TARGET_ARCH} too? I notice builddtb below sets only MACHINE.

Don't see that MACHINE_ARCH is used, but it's always a good idea to set MACHINE and MACHINE_ARCH in pairs.

This revision is now accepted and ready to land.Mar 6 2023, 8:36 PM
This revision was automatically updated to reflect the committed changes.