When building customized FreeBSD without tarfs module, this regression test fail because
it can't load the module.
Details
Details
- Reviewers
des asomers - Group Reviewers
tests - Commits
- rGe78dc78e517a: testing: skip tarfs tests if module is not loadable.
mv /boot/kernel/tarfs.ko /boot/kernel/tarfs.ko.bak # kyua test sys/fs/tarfs/ sys/fs/tarfs/tarfs_test:tarfs_basic -> skipped: This test requires tarfs and could not load it [0.020s] sys/fs/tarfs/tarfs_test:tarfs_notdir_device -> skipped: This test requires tarfs and could not load it [0.020s] sys/fs/tarfs/tarfs_test:tarfs_notdir_dot -> skipped: This test requires tarfs and could not load it [0.019s] sys/fs/tarfs/tarfs_test:tarfs_notdir_dotdot -> skipped: This test requires tarfs and could not load it [0.019s] sys/fs/tarfs/tarfs_test:tarfs_notdir_file -> skipped: This test requires tarfs and could not load it [0.019s] Results file id is usr_tests.20230228-200204-811621 Results saved to /root/.kyua/store/results.usr_tests.20230228-200204-811621.db 5/5 passed (0 failed)
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The kldload check function seems like it should be in a common function. Also: I might reword the message to state: “This test requires the tarfs kernel module (not available).”
tests/sys/fs/tarfs/tarfs_test.sh | ||
---|---|---|
51 | Should this use umount -f ? |
tests/sys/fs/tarfs/tarfs_test.sh | ||
---|---|---|
51 | Or maybe a different sanity check to run beforehand, like ‘test -d “${mnt}”’? |
Comment Actions
About the "not available", I didn't add this precision because in some case it could be a loading failure too (like a child module not available).