Page MenuHomeFreeBSD

nfsd: use static memory for per-vnet struct fha_params
AbandonedPublic

Authored by glebius on Feb 23 2023, 6:27 AM.
Tags
None
Referenced Files
F102963842: D38742.diff
Tue, Nov 19, 6:41 AM
Unknown Object (File)
Sun, Nov 17, 3:49 AM
Unknown Object (File)
Tue, Oct 22, 8:24 AM
Unknown Object (File)
Oct 9 2024, 12:28 PM
Unknown Object (File)
Sep 19 2024, 2:34 AM
Unknown Object (File)
Sep 16 2024, 7:25 AM
Unknown Object (File)
Sep 10 2024, 4:10 PM
Unknown Object (File)
Sep 10 2024, 1:49 PM
Subscribers

Details

Reviewers
rmacklem
jamie
bz
Summary

Use VIMAGE framework to instantiate per-VNET static structures. The
dynamic sysctl creation seems to be unneeded from the very beginning
of this module, use static initialization for them, too.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49974
Build 46866: arc lint + arc unit

Event Timeline

Due to vnet space constraints, I would prefer to
leave the fha_param structure malloc'd.

I will take the sysctls out of it and try and vnet
them. These sysctls are rarely used, so having
them in prison0 only is not that serious a problem,
but I will try and fix it.

Btw, with everything malloc'd, the vnet footprint
for the NFS server and all related stuff (krpc, kgssapi)
is about 500 bytes. Since "struct fha_param" is 10120bytes,
making it static will probably make "kldload nfsd.ko" fail.