Page MenuHomeFreeBSD
Differential D38736

hwpmc: Don't wrap entire files in #ifdef DEV_ACPI.
ClosedPublic
Actions

Authored by jhb on Feb 22 2023, 10:02 PM.
Tags
None
Referenced Files
F115270099: D38736.id118136.diff
Tue, Apr 22, 2:09 AM
Unknown Object (File)
Sun, Apr 20, 11:09 PM
Unknown Object (File)
Sun, Apr 20, 10:55 PM
Unknown Object (File)
Sun, Apr 20, 10:21 PM
Unknown Object (File)
Sun, Apr 20, 9:13 PM
Unknown Object (File)
Sun, Apr 20, 8:47 PM
Unknown Object (File)
Mar 20 2025, 10:02 AM
Unknown Object (File)
Mar 20 2025, 10:02 AM
View All 74 Files
Subscribers
brooks
emaste

Details

Reviewers
andrew
imp
gnn
manu
Commits
rGd90188eff5c5: hwpmc: Don't wrap entire files in #ifdef DEV_ACPI.
Summary

A subsequent commit will instead use existing infrastructure to
exclude the files from hwpmc.ko for non-ACPI builds. Note that the
original commit left the files as optional in sys/conf/files.arm64.

This reverts commit 751d88119fdc1dff71d1390c7768942a9b857bc6.

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 22 2023, 10:02 PM
Herald added a reviewer: gnn. · View Herald TranscriptFeb 22 2023, 10:02 PM
Herald added a reviewer: manu. · View Herald Transcript
Herald added a subscriber: emaste. · View Herald Transcript
jhb requested review of this revision.Feb 22 2023, 10:02 PM
jhb added a child revision: D38737: sys/modules: fix bogus OPT_ACPI tests.
Harbormaster completed remote builds in B49970: Diff 117789.Feb 22 2023, 10:02 PM
brooks added a subscriber: brooks.Feb 22 2023, 10:11 PM
brooks added inline comments.
sys/arm64/arm64/cmn600.c
4

Were these copyright changes intended?

brooks added a comment.Feb 22 2023, 10:16 PM

*sigh* immediately after submitting I noticed that this was a revert.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 1 2023, 6:34 PM
Closed by commit rGd90188eff5c5: hwpmc: Don't wrap entire files in #ifdef DEV_ACPI. (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGd90188eff5c5: hwpmc: Don't wrap entire files in #ifdef DEV_ACPI..

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
7 lines
dev/
hwpmc/
9 lines
6 lines
modules/
hwpmc/
2 lines

Diff 118136

View Options

sys/arm64/arm64/cmn600.c

Loading...
View Options

sys/dev/hwpmc/hwpmc_cmn600.c

Loading...
View Options

sys/dev/hwpmc/pmu_dmc620.c

Loading...
View Options

sys/modules/hwpmc/Makefile

Loading...