Page MenuHomeFreeBSD

vgapci: Don't create a drm helper.
ClosedPublic

Authored by dchagin on Feb 12 2023, 3:54 PM.
Tags
None
Referenced Files
F102652447: D38546.diff
Fri, Nov 15, 9:17 AM
Unknown Object (File)
Tue, Nov 5, 1:13 PM
Unknown Object (File)
Fri, Oct 18, 6:28 AM
Unknown Object (File)
Sep 20 2024, 3:46 PM
Unknown Object (File)
Sep 11 2024, 1:35 PM
Unknown Object (File)
Sep 11 2024, 1:35 PM
Unknown Object (File)
Sep 4 2024, 8:20 PM
Unknown Object (File)
Aug 19 2024, 7:01 AM
Subscribers

Details

Summary

Simply speaking, being started the drm-kmod driver should create sysfs helpers,
which is «drm» class devices, with the unit number 0, 128 and, perhaps 64.
If a drm helper created by vgapci driver with the corresponding unit number
exists then the drm-kmod driver initialize it by the device_initialize() lkpi
method, otherwise drm-kmod driver create new «drm» device.
For hw, where two or more different GPU installed, it's not guaranteed that
the order of loading GPU drivers will be the same as the vgapci devices numbered.
I.e., on hw where vgapci0 is Nvidia GPU and vgapci1 is Intel GPU, when drm-kmod
loaded first it will use drm0 helper of vgapci0 device.
There is no problem for drm-kmod driver unless we do not traverse device
tree, as needed for https://reviews.freebsd.org/D38545.

drm-kmod os ok for this change as it has fallback to create corresponding
drm device.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 49716
Build 46606: arc lint + arc unit

Event Timeline

ping? I have tested with nvidia, it seems nvidia driver does not depend on this too.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2023, 5:27 PM
This revision was automatically updated to reflect the committed changes.