powerpc: remove nexus_get_cpus()
ClosedPublic
Actions

Authored by mhorne on Feb 10 2023, 5:36 PM.

Details

Reviewers

jhb
imp
jhibbits

Commits

rG3ca605d19b2e: powerpc: remove nexus_get_cpus()
rG660609698622: powerpc: remove nexus_get_cpus()

Summary

It is identical in functionality to root_get_cpus().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.Feb 10 2023, 5:36 PM

mhorne created this revision.

mhorne added a parent revision: D38493: ofwbus: only allow unit number zero.

Harbormaster completed remote builds in B49670: Diff 116951.Feb 10 2023, 5:36 PM

jhb added inline comments.Feb 10 2023, 6:10 PM

sys/powerpc/powerpc/nexus.c
222	This one does return `all_cpus` so is a duplicate.
sys/x86/x86/nexus.c
709 ↗	(On Diff #116951)	root_get_cpus returns `all_cpus` here, not `intr_cpus`. The difference is that `intr_cpus` doesn't include SMT threads.

mhorne added inline comments.Feb 10 2023, 6:14 PM

sys/x86/x86/nexus.c
709 ↗	(On Diff #116951)	Oh indeed, I read that a bit too fast.

Drop the x86 changes.

Harbormaster completed remote builds in B49740: Diff 117106.Feb 13 2023, 5:39 PM

mhorne retitled this revision from nexus: remove nexus_get_cpus() to powerpc: remove nexus_get_cpus().Feb 13 2023, 5:39 PM

mhorne edited the summary of this revision. (Show Details)

jhibbits accepted this revision.Feb 15 2023, 2:24 PM

This revision is now accepted and ready to land.Feb 15 2023, 2:24 PM

Closed by commit rG660609698622: powerpc: remove nexus_get_cpus() (authored by mhorne). · Explain WhyFeb 16 2023, 9:30 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG660609698622: powerpc: remove nexus_get_cpus().

mhorne added a commit: rG3ca605d19b2e: powerpc: remove nexus_get_cpus().Mar 7 2023, 4:55 PM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

nexus.c

21 lines

Diff 117477

View Options

sys/powerpc/powerpc/nexus.c

powerpc: remove nexus_get_cpus()ClosedPublicActions