bhyve: Resume is broken after 39ec056e6dbd 'vmm: Rework snapshotting ...'

[gusev.vitaliy_gmail.com]

Summary

vmx_snapshot() and svm_snapshot() do not save any data and error occurs at resume:

Restoring kernel structs...
vm_restore_kern_struct: Kernel struct size was 0 for: vmx
Failed to restore kernel structs.

Sponsored by: vStack

Test Plan

Perform Suspend/Resume, Resume previously saved snapshots. VM Ubuntu 22.04.

[corvink]

LGTM

[markj]

The commit hash in the review title doesn't match anything in the src repo.

[jhb]

sys/amd64/vmm/amd/svm.c

2421

You still need this though don't you? This is why I didn't just remove the hook entirely.

[gusev.vitaliy_gmail.com]

sys/amd64/vmm/amd/svm.c

2421

This is no-op operation and I think added by mistake.

static __inline int
flush_by_asid(void)
{

        return (svm_feature & AMD_CPUID_SVM_FLUSH_BY_ASID);
}

[jhb]

sys/amd64/vmm/amd/svm.c

2421

Ah, ok. In that case, you should probably remove the vmx_snapshot and svm_snapshot methods and the slot for them in struct vmm_ops, etc. as well.

[gusev.vitaliy_gmail.com]

In D38476#875774, @markj wrote:

The commit hash in the review title doesn't match anything in the src repo.

Thanks, corrected.

[gusev.vitaliy_gmail.com]

sys/amd64/vmm/amd/svm.c

2421

I thought about it, but it will produce a lot of code that could add slowdown of a review process and to do more testing. But if you want I can do it.

[gusev.vitaliy_gmail.com]

sys/amd64/vmm/amd/svm.c

2421

@jhb Follow up nvlist changes for suspend/resume should clean it anyway.

[gusev.vitaliy_gmail.com]

@jhb Current things are good enough to proceed?

[gusev.vitaliy_gmail.com]

Removed "vmmops_snapshot" and related code.

[gusev.vitaliy_gmail.com]

@jhb Updated diff accordingly with your note.

[gusev.vitaliy_gmail.com]

Could anyone commit it ?