Page MenuHomeFreeBSD
Differential D38404

update manpages for huawei 3G/4G LTE modem
AcceptedPublic
Actions

Authored by fbsd_paepcke.de on Feb 6 2023, 5:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 4:27 AM
Unknown Object (File)
Wed, Oct 23, 5:30 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
Unknown Object (File)
Wed, Oct 23, 5:29 PM
View All 85 Files
Subscribers
None

Details

Reviewers
imp
fbsd_paepcke.de
Summary
  • update cdce.4 and UPDATING to reflect change set around 1997d3a4a9f2
  • fix bug reported by: David BOYER, missing entry for E3372h Model already in NCM mode in u3g.c

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fbsd_paepcke.de requested review of this revision.Feb 6 2023, 5:28 PM
fbsd_paepcke.de created this revision.
fbsd_paepcke.de updated this revision to Diff 116585.Feb 6 2023, 5:31 PM

typo

fbsd_paepcke.de retitled this revision from updates for 1997d3a4a9f2 and following (D38383) to cdce / man pages for 1997d3a4a9f2 and following (D38383) .Feb 6 2023, 5:37 PM
fbsd_paepcke.de edited the summary of this revision. (Show Details)
fbsd_paepcke.de updated this revision to Diff 116629.Feb 6 2023, 7:17 PM
fbsd_paepcke.de updated this revision to Diff 116676.Feb 7 2023, 6:54 AM
fbsd_paepcke.de updated this revision to Diff 116686.Feb 7 2023, 8:21 AM
fbsd_paepcke.de updated this revision to Diff 116744.Feb 7 2023, 10:18 PM
fbsd_paepcke.de retitled this revision from cdce / man pages for 1997d3a4a9f2 and following (D38383) to update manpages for huawei 3G/4G LTE modem.
fbsd_paepcke.de edited the summary of this revision. (Show Details)
imp accepted this revision.Feb 8 2023, 9:33 PM

looks sane... but why the extra device?

This revision is now accepted and ready to land.Feb 8 2023, 9:33 PM
fbsd_paepcke.de added a comment.EditedFeb 9 2023, 7:15 AM
In D38404#874948, @imp wrote:

looks sane... but why the extra device?

Its a bugfix.

There was a bug report here from David Boyer:
https://github.com/freebsd/freebsd-src/pull/633

He reported the bug (incl. fix proposal!) to the closed PR, because we have no issue tracker in github.

He worked around the problem (that this patchset fixed) by flashing a special firmware and ended in an unsupported situation. Adding this Device (that normally should not appear in the wild) we can cover all edge cases, including people with custom firmware or wild modeswitch solutions (eg. pfsense done as workaround ), so it should be safe to MFC this patchset now.

fbsd_paepcke.de accepted this revision.Feb 9 2023, 8:46 PM
fbsd_paepcke.de added a comment.Feb 10 2023, 3:27 AM

... should I split it into two? (If not, who can push?)

Revision Contents
Changeset List

PathSize
4 lines
share/
man/
man4/
20 lines
sys/
dev/
usb/
serial/
1 line

Diff 116744

View Options

UPDATING

Loading...
View Options

share/man/man4/cdce.4

Loading...
View Options

sys/dev/usb/serial/u3g.c

Loading...