Page MenuHomeFreeBSD
Differential D38373

libmd / md5: Add SHA-512/224.
ClosedPublic
Actions

Authored by des on Feb 3 2023, 3:21 PM.
Tags
None
Referenced Files
F102131099: D38373.diff
Fri, Nov 8, 12:13 AM
Unknown Object (File)
Wed, Nov 6, 2:46 PM
Unknown Object (File)
Tue, Nov 5, 11:28 AM
Unknown Object (File)
Thu, Oct 31, 8:15 PM
Unknown Object (File)
Sun, Oct 20, 3:36 PM
Unknown Object (File)
Thu, Oct 17, 6:16 AM
Unknown Object (File)
Wed, Oct 16, 6:12 PM
Unknown Object (File)
Mon, Oct 14, 2:46 PM
View All Files
Subscribers
allanjude
bcr
imp
kevans
kib
yuri_aetern.org

Details

Reviewers
kevans
yuri_aetern.org
allanjude
Group Reviewers
Klara
manpages
Commits
rGe04ee7d95ef6: libmd / md5: Add SHA-512/224.
rG2768d7056727: libmd / md5: Add SHA-512/224.
Summary

While there, remove .Tn from man pages.

Also remove an obsolete comment about the 80386.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Feb 3 2023, 3:21 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2023, 3:21 PM
des requested review of this revision.Feb 3 2023, 3:21 PM
Harbormaster completed remote builds in B49510: Diff 116395.Feb 3 2023, 3:21 PM
des added a parent revision: D38372: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 3 2023, 3:21 PM
des added a reviewer: Klara.Feb 3 2023, 3:24 PM
yuri_aetern.org added a subscriber: yuri_aetern.org.Feb 3 2023, 6:09 PM
yuri_aetern.org added inline comments.
lib/libmd/sha512.3
226
STYLE: useless macro: Tn

.Tn is deprecated and does nothing; while it's already used in this man page, not adding new entries might be helpful

kevans accepted this revision.Feb 3 2023, 7:00 PM
kevans added a subscriber: kevans.

LGTM; remove .Tn pre-commit or maybe let's do a pass after to address mandoc complaints (I'm assuming there's probably others)

This revision is now accepted and ready to land.Feb 3 2023, 7:00 PM
des updated this revision to Diff 116464.Feb 4 2023, 1:07 PM

Removed useless .Tn macro from man pages, deliberately not bumping Dd since neither the text nor the appearance has changed.

This revision now requires review to proceed.Feb 4 2023, 1:07 PM
Harbormaster completed remote builds in B49522: Diff 116464.Feb 4 2023, 1:07 PM
des edited the summary of this revision. (Show Details)Feb 4 2023, 1:09 PM
des added a reviewer: yuri_aetern.org.
des mentioned this in D38372: sha512_224: Fix SHA512_224_Final() on little-endian machines..Feb 6 2023, 12:11 PM
des added a reviewer: manpages.
des marked an inline comment as done.Feb 6 2023, 12:22 PM
kib added a subscriber: kib.Feb 6 2023, 12:57 PM
kib added inline comments.
lib/libmd/sha.3
187

We do not boot on i386 for long time. This section can be removed.

des updated this revision to Diff 116561.Feb 6 2023, 1:02 PM

Hook up the SHA-512/224 tests.

Harbormaster completed remote builds in B49556: Diff 116561.Feb 6 2023, 1:02 PM
des updated this revision to Diff 116562.Feb 6 2023, 1:10 PM

Remove comment about the 80386.

Harbormaster completed remote builds in B49557: Diff 116562.Feb 6 2023, 1:10 PM
des marked an inline comment as done.Feb 6 2023, 1:10 PM
bcr accepted this revision as: manpages.Feb 6 2023, 2:06 PM
bcr added a subscriber: bcr.

OK from manpages.

allanjude accepted this revision as: allanjude.Feb 6 2023, 4:07 PM
allanjude added a subscriber: allanjude.

Reviewed by: allanjude

This revision is now accepted and ready to land.Feb 6 2023, 4:07 PM
des retitled this revision from libmd: Add SHA-512/224. to libmd / md5: Add SHA-512/224..Feb 6 2023, 4:26 PM
des updated this revision to Diff 116577.Feb 6 2023, 4:26 PM

Add missing md5 part.

This revision now requires review to proceed.Feb 6 2023, 4:26 PM
Harbormaster completed remote builds in B49568: Diff 116577.Feb 6 2023, 4:26 PM
des edited the summary of this revision. (Show Details)Feb 6 2023, 4:27 PM
kevans accepted this revision.Feb 6 2023, 4:32 PM
This revision is now accepted and ready to land.Feb 6 2023, 4:32 PM
Closed by commit rG2768d7056727: libmd / md5: Add SHA-512/224. (authored by des). · Explain WhyFeb 6 2023, 5:04 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG2768d7056727: libmd / md5: Add SHA-512/224..
des added a commit: rGe04ee7d95ef6: libmd / md5: Add SHA-512/224..Feb 9 2023, 8:42 PM

Revision Contents
Changeset List

PathSize
lib/
libmd/
40 lines
10 lines
7 lines
37 lines
7 lines
54 lines
3 lines
3 lines
sbin/
md5/
4 lines
21 lines
17 lines
tests/
1 line
9 lines
8 lines
8 lines

Diff 116581

View Options

lib/libmd/Makefile

Loading...
View Options

lib/libmd/mdX.3

Loading...
View Options

lib/libmd/ripemd.3

Loading...
View Options

lib/libmd/sha.3

Loading...
View Options

lib/libmd/sha256.3

Loading...
View Options

lib/libmd/sha512.3

Loading...
View Options

lib/libmd/shadriver.c

Loading...
View Options

lib/libmd/skein.3

Loading...
View Options

sbin/md5/Makefile

Loading...
View Options

sbin/md5/md5.1

Loading...
View Options

sbin/md5/md5.c

Loading...
View Options

sbin/md5/tests/algorithms.txt

Loading...
View Options

sbin/md5/tests/self-test.sha512t224.chk

Loading...
View Options

sbin/md5/tests/sha512t224.digest

Loading...
View Options

sbin/md5/tests/sha512t224sum.digest

Loading...