Details
- Reviewers
dchagin - Commits
- rG52d984831d82: Port Linuxulator to IfAPI
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Will do. I naively lumped them together, thinking they were interrelated.
sys/compat/linux/linux_ioctl.c | ||
---|---|---|
2132 | This API is in D38348. | |
2137 | The API, in D38348, will return on non-zero callback return. I chose that because from what I've found, the vast majority of iterations over V_ifnet are to search for something and break out after finding that something, whereas the majority of iterations over the if_maddr and if_addr are to apply some transform over all addresses on an interface, and searching for a specific address is less common. | |
sys/compat/linux/linux_util.h | ||
45 ↗ | (On Diff #116230) | Oops, this shouldn't have gone in. |
sys/compat/linux/linux.c | ||
---|---|---|
280 |
sys/compat/linux/linux.c | ||
---|---|---|
280 | Tried changing all uses of struct ifnet * in the Linuxulator, but ran into a problem with linux_util.h. Need to include <net/if.h>, and ifr_name conflicts with a #define in linux32/linux.h, so I'll punt for now and try to address it later. |
sys/compat/linux/linux.c | ||
---|---|---|
280 | ah, In my local queue I have some changes for linux_util.h, I would prefer to commit in on a next week, before you. |