Page MenuHomeFreeBSD

Port Linuxulator to IfAPI
ClosedPublic

Authored by jhibbits on Feb 1 2023, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 4, 9:39 PM
Unknown Object (File)
Sat, Oct 26, 8:25 AM
Unknown Object (File)
Mon, Oct 21, 7:11 PM
Unknown Object (File)
Oct 5 2024, 3:59 AM
Unknown Object (File)
Oct 2 2024, 8:00 PM
Unknown Object (File)
Oct 2 2024, 8:34 AM
Unknown Object (File)
Oct 2 2024, 8:34 AM
Unknown Object (File)
Sep 30 2024, 1:45 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

please, linsysfs, linprocfs and /compat/linux by separate commits.

sys/compat/linux/linux_ioctl.c
2132

can't find its definition

2137

at least this weird API

sys/compat/linux/linux_util.h
45 ↗(On Diff #116230)

should be in separate commit

please, linsysfs, linprocfs and /compat/linux by separate commits.

Will do. I naively lumped them together, thinking they were interrelated.

sys/compat/linux/linux_ioctl.c
2132

This API is in D38348.

2137

The API, in D38348, will return on non-zero callback return. I chose that because from what I've found, the vast majority of iterations over V_ifnet are to search for something and break out after finding that something, whereas the majority of iterations over the if_maddr and if_addr are to apply some transform over all addresses on an interface, and searching for a specific address is less common.

sys/compat/linux/linux_util.h
45 ↗(On Diff #116230)

Oops, this shouldn't have gone in.

Address feedback. Break out linprocfs and linsysfs, revert inintended change.

dchagin added inline comments.
sys/compat/linux/linux.c
280
This revision is now accepted and ready to land.Feb 3 2023, 6:39 PM
sys/compat/linux/linux.c
280

Tried changing all uses of struct ifnet * in the Linuxulator, but ran into a problem with linux_util.h. Need to include <net/if.h>, and ifr_name conflicts with a #define in linux32/linux.h, so I'll punt for now and try to address it later.

sys/compat/linux/linux.c
280

ah, In my local queue I have some changes for linux_util.h, I would prefer to commit in on a next week, before you.
as I plan to mfc it. About ifr_name - we can rename it to lifr_name, etc... for example

I'll keep this in my queue and wait for your change to land first, then. Thanks!

I'll keep this in my queue and wait for your change to land first, then. Thanks!

ugh, sorry for the delay, covid(( Im finished, thank you!

This revision was automatically updated to reflect the committed changes.