IfAPI: Add iterator to loop over all interfaces

[jhibbits]

Summary

Sometimes it's useful to iterate over all interfaces in the current
VNET, as the linuxulator does in several places.

Unlike other iterators in the IfAPI this propagates any error received
up to the caller, instead of returning a count.

Sponsored by: Juniper Networks, Inc.

[jhibbits]

Add missing bits...

[melifaro]

sys/net/if.c

4474

Nit: worth asserting net epoch and cb!=null

[glebius]

sys/net/if.c

4474

Not sure about asserting the cb, as it would crash anyway. But the NET_EPOCH_ASSERT() needs to be here.

sys/net/if_var.h

510

I'd suggest to name the function if_foreach() and typedef as if_foreach_cb_t. The reason why I'd suggest to avoid "ifnet" is that a code that is fully converted to the new API should return empty on grep ifnet foo.c. That was suggested back in 2012 and it still works - just checked the drivers you recently converted.

I'd also suggest to place these declarations down at line 667, where the address iterating functions are declared.

[jhibbits]

sys/net/if_var.h

510

I was also thinking if_foreach(), and hesitated because it doesn't convey "foreach what?" and all other "if_" functions in the IfAPI act on a single interface. But just as happy to make the change, and move it.

[melifaro]

if_foreach_ifp ?

[glebius]

In D38348#871789, @melifaro wrote:

if_foreach_ifp ?

The prefix already stands for interface, so why the tautology?

[jhibbits]

Address @glebius's feedback.