Details

share/man/man4/kvmclock.4
25	I probably won't, I'll just remove this tag.
79	Prior to the patches in D38341-2, assuming they get committed. :) I'm not really sure how to express that here. Maybe just say, anything using a libc.so older than 14.0-RELEASE's or anything statically linked before 14.0 came out.

imp accepted this revision.Feb 1 2023, 5:41 PM

imp added inline comments.

share/man/man4/kvmclock.4
79	Yea prior to 14.0... unless this get merged back to 13.2. Release granularity likely is fine

This revision is now accepted and ready to land.Feb 1 2023, 5:41 PM

Since the driver is in 13.1, perhaps MFC?

share/man/man4/kvmclock.4
2–23	Per https://docs.freebsd.org/en/articles/license-guide/#pref-license, this should have a SDPX license identifier. Whether to keep the license text as well is (I think) up to you.
25	Not needed anymore for new files.
74	US spelling
85	Clarify "systems"? kernel?

Review feedback.

This revision now requires review to proceed.Feb 1 2023, 7:15 PM

kib added inline comments.Feb 1 2023, 8:30 PM

share/man/man4/kvmclock.4
53	So these are no longer system calls. Might be call them functions?
79	Why libc.so and not libc.so.7? libc.so is not a shared object at all.

/usr/lib/libc.so -> /lib/libc.so.7
Refer to clock_gettime() as a function rather than a system call since that's more accurate in this context.

kib accepted this revision.Feb 1 2023, 9:01 PM

This revision is now accepted and ready to land.Feb 1 2023, 9:01 PM

Device name correction (if I'm right) can be fixed on commit.

share/man/man4/kvmclock.4
38	`kvmclock`, I think?

markj marked an inline comment as done.Feb 1 2023, 10:36 PM

markj added inline comments.

share/man/man4/kvmclock.4
38	`kvm_clock` is correct, unfortunately. The path is sys/dev/kvm_clock. But internally the driver is called `kvmclock`.

This revision was automatically updated to reflect the committed changes.

markj marked an inline comment as done.

man4: Add a manual page for kvmclock
ClosedPublic
Actions