Page MenuHomeFreeBSD

Handle ERELOOKUP from VOP_FSYNC()
ClosedPublic

Authored by kib on Jan 18 2023, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 21 2024, 5:49 PM
Unknown Object (File)
Oct 3 2024, 10:51 PM
Unknown Object (File)
Oct 2 2024, 6:10 AM
Unknown Object (File)
Oct 1 2024, 10:54 AM
Unknown Object (File)
Sep 21 2024, 10:55 PM
Unknown Object (File)
Sep 21 2024, 3:05 PM
Unknown Object (File)
Sep 20 2024, 9:45 PM
Unknown Object (File)
Sep 18 2024, 3:02 AM
Subscribers

Details

Summary

We need to repeat the operation if the vnode was relocked.

Reported by: markj

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Jan 18 2023, 9:12 PM

Thanks, this fixes the panic I saw.

sys/vm/vm_object.c
1238

Why isn't it necessary to relock the vnode here like we do in md? And if we can simply call VOP_FSYNC() in a loop like this, why not handle the retry entirely in the VOP?

sys/vm/vm_object.c
1238

Generally it is useful to unlock the vnode since it allows SU thread and bufdaemon to clean more dependencies that perhaps caused the relock during ffs_fsyncvnode().

I added the relock there.

Relock for vm_object_sync()

kib marked an inline comment as done.Jan 18 2023, 9:57 PM
markj added inline comments.
sys/vm/vm_object.c
1244
This revision is now accepted and ready to land.Jan 18 2023, 10:15 PM
kib marked an inline comment as done.

Avoid duplicating VOP_FSYNC() call.
Move comment to the more logical place. Make it stylish.

This revision now requires review to proceed.Jan 18 2023, 10:31 PM
markj added inline comments.
sys/vm/vm_object.c
1249
This revision is now accepted and ready to land.Jan 19 2023, 3:49 PM