Page MenuHomeFreeBSD
Differential D38091

Improve debuggability of VOP_* locking assertions
ClosedPublic
Actions

Authored by jah on Jan 16 2023, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 26, 6:00 PM
Unknown Object (File)
Fri, Jan 24, 5:16 PM
Unknown Object (File)
Wed, Jan 22, 1:00 AM
Unknown Object (File)
Thu, Jan 16, 4:21 AM
Unknown Object (File)
Dec 2 2024, 7:14 AM
Unknown Object (File)
Nov 28 2024, 6:00 PM
Unknown Object (File)
Nov 18 2024, 2:33 AM
Unknown Object (File)
Nov 18 2024, 1:30 AM
View All 56 Files
Subscribers
imp

Details

Reviewers
kib
markj
mjg
Commits
rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions
Summary

Include the phase and argument field to make it easier to determine
at a glance where the failure originated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jah created this revision.Jan 16 2023, 9:41 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 16 2023, 9:41 PM
jah requested review of this revision.Jan 16 2023, 9:41 PM
Harbormaster completed remote builds in B49136: Diff 115215.Jan 16 2023, 9:41 PM
kib added a comment.Jan 16 2023, 9:56 PM

Could you please show an example of the new output?

jah added a comment.Jan 16 2023, 10:03 PM
In D38091#865308, @kib wrote:

Could you please show an example of the new output?

This is what I saw a few hours ago when I used it to help me debug a unionfs issue:

VOP_MKDIR Error (dvp): vnode <...> is not exclusive locked but should be

kib accepted this revision.Jan 17 2023, 12:27 AM
This revision is now accepted and ready to land.Jan 17 2023, 12:27 AM
markj accepted this revision.Jan 18 2023, 3:52 PM
Closed by commit rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions (authored by jah). · Explain WhyJan 19 2023, 3:59 AM
This revision was automatically updated to reflect the committed changes.
jah added a commit: rG5a4a83fd0e67: Improve debuggability of VOP_* locking assertions.

Revision Contents
Changeset List

PathSize
sys/
tools/
8 lines

Diff 115298

View Options

sys/tools/vnode_if.awk

Loading...