Page MenuHomeFreeBSD
Differential D38031

Add the fixed memory type to the pci ecam driver
ClosedPublic
Actions

Authored by andrew on Jan 12 2023, 9:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 10:54 AM
Unknown Object (File)
Fri, Nov 15, 10:44 AM
Unknown Object (File)
Fri, Nov 15, 8:58 AM
Unknown Object (File)
Tue, Nov 5, 8:50 PM
Unknown Object (File)
Thu, Oct 24, 2:59 AM
Unknown Object (File)
Wed, Oct 23, 7:01 AM
Unknown Object (File)
Oct 9 2024, 12:30 PM
Unknown Object (File)
Sep 22 2024, 2:26 PM
View All 80 Files
Subscribers
imp
kevans

Details

Reviewers
jhb
fuz
Group Reviewers
arm64
Commits
rG253e4c56c8a6: Add the fixed memory type to the pci ecam driver
rG896f556205c8: Add the fixed memory type to the pci ecam driver
Summary

Add ACPI_RESOURCE_TYPE_FIXED_MEMORY32 to the PCI ECAM driver. This is
used on the Microsoft Dev Kit 2023 and reportedly the Lenovo x13s.

Tested by: Robert Clausecker <fuz@fuz.su> (Earlier version)
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Jan 12 2023, 9:41 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 12 2023, 9:41 AM
andrew requested review of this revision.Jan 12 2023, 9:41 AM
Harbormaster completed remote builds in B49071: Diff 114989.Jan 12 2023, 9:41 AM
fuz accepted this revision.Jan 12 2023, 10:55 AM

This patch tests ok on the Windows 2023 Dev Kit.

sys/dev/pci/pci_host_generic_acpi.c
151

Code could be made less repetitive by moving the standard case out of the switch statement.

This revision is now accepted and ready to land.Jan 12 2023, 10:55 AM
kevans added a subscriber: kevans.Jan 12 2023, 8:04 PM
kevans added inline comments.
sys/dev/pci/pci_host_generic_acpi.c
171
andrew updated this revision to Diff 115044.Jan 13 2023, 4:03 PM
  • Use the correct union member to find the resource type
  • Fix a typo
This revision now requires review to proceed.Jan 13 2023, 4:03 PM
Harbormaster completed remote builds in B49089: Diff 115044.Jan 13 2023, 4:03 PM
andrew marked an inline comment as done.Jan 13 2023, 4:06 PM
andrew added inline comments.
sys/dev/pci/pci_host_generic_acpi.c
151

I switched to using the correct union member rather than rely on it being part of the Address member.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2023, 9:41 AM
Closed by commit rG896f556205c8: Add the fixed memory type to the pci ecam driver (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG896f556205c8: Add the fixed memory type to the pci ecam driver.
fuz added a comment.Apr 3 2023, 9:38 PM

This patch apparently has not been MFC'ed to 13-stable, preventing the Windows 2023 Dev Kit from booting 13.2-RC6 (in conjunction with D37765 and hw.pac.enable=0). Could this one be MFC'ed?

andrew added a commit: rG253e4c56c8a6: Add the fixed memory type to the pci ecam driver.May 15 2023, 3:46 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
23 lines

Diff 115253

View Options

sys/dev/pci/pci_host_generic_acpi.c

Loading...