Build RACK and BBR TCP stacks as a part of LINT
ClosedPublic
Actions

Authored by gallatin on Dec 29 2022, 9:48 PM.

Details

Reviewers

tuexen
rrs
jtl
rscheff
manu

Group Reviewers

transport

Commits

rG8ea418299548: tcp: Build RACK and BBR stacks as a part of LINT

Summary

When RACK and BBR were added to the kernel, they were hidden behind ' WITH_EXTRA_TCP_STACKS=1'. Unfortunately, that was never added to any NOTES file, so RACK is not tested with the various LINT-NOINET, LINT-NOINET6, and LINT-NOIP kernels. This leads to the stacks sometimes being broken in these kernels, since changes to them are not build tested. I discovered this because I have WITH_EXTRA_TCP_STACKS=1 in my src.conf, and saw 'make universe' fail when testing another change.

This change fixes rack so that it compiles with the LINT-NO* kernels, and adds WITH_EXTRA_TCP_STACKS=1 to all NOTES kernels (trying to follow the style in each NOTES file), so that rack and bbr are compile tested regularly.

This change does not alter the supported status of RACK or BBR, and replaces D37715

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gallatin created this revision.Dec 29 2022, 9:48 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 29 2022, 9:48 PM

Herald added a reviewer: transport. · View Herald Transcript

Herald added subscribers: glebius, melifaro, jhibbits and 3 others. · View Herald Transcript

gallatin requested review of this revision.Dec 29 2022, 9:48 PM

gallatin mentioned this in D37715: tcp: build rack and bbr as part of normal kernel builds.

I actually prefer D37715. Isn't that what we have discussed on the TCP call on December 15th?

imp added inline comments.Dec 30 2022, 4:50 AM

sys/arm/conf/NOTES
85 ↗	(On Diff #114642)	I think that you could add this to sys/conf/NOTES instead of all the arch NOTES files.

Add WITH_EXTRA_TCP_STACKS to common NOTES file, as suggested by @imp

In D37903#861260, @glebius wrote:

I actually prefer D37715. Isn't that what we have discussed on the TCP call on December 15th?

That's a bit more than I want to take on..

sys/arm/conf/NOTES
85 ↗	(On Diff #114642)	Thanks, that's so much cleaner!

gbe added a subscriber: gbe.Jan 3 2023, 10:23 AM

@gallatin transport Has had anyone the time to look at https://reviews.freebsd.org/D36538? At least TCPHPTS should be included somewhere and the documentation should also be updated!

In D37903#861938, @gbe wrote:

@gallatin transport Has had anyone the time to look at https://reviews.freebsd.org/D36538? At least TCPHPTS should be included somewhere and the documentation should also be updated!

I left a comment on that review. For this review, HPTS is included in LINT. And the scope of this is to simply ensure these stacks compile..

Rebased to today's current.

rrs accepted this revision.Jan 10 2023, 9:07 PM

This revision is now accepted and ready to land.Jan 10 2023, 9:07 PM

Closed by commit rG8ea418299548: tcp: Build RACK and BBR stacks as a part of LINT (authored by gallatin). · Explain WhyJan 10 2023, 9:18 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG8ea418299548: tcp: Build RACK and BBR stacks as a part of LINT.