vmm: Free vCPUs when destroying them.
ClosedPublic
Actions

Authored by jhb on Dec 9 2022, 12:58 AM.

Details

Reviewers

markj
andrew
corvink

Group Reviewers

bhyve

Commits

rGc44d097dcf92: vmm: Free vCPUs when destroying them.
rGaf3b48e10198: vmm: Free vCPUs when destroying them.

Summary

Reported by: andrew

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48669
Build 45555: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 9 2022, 12:58 AM

Herald added a reviewer: bhyve. · View Herald TranscriptDec 9 2022, 12:58 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Dec 9 2022, 12:58 AM

Harbormaster completed remote builds in B48669: Diff 113969.Dec 9 2022, 12:58 AM

andrew accepted this revision.Dec 9 2022, 7:13 AM

This revision is now accepted and ready to land.Dec 9 2022, 7:13 AM

corvink accepted this revision.Dec 9 2022, 7:39 AM

corvink added a subscriber: corvink.

corvink added inline comments.

sys/amd64/vmm/vmm.c
670	Should we set `vm->vcpu[i]` to NULL after calling `vcpu_cleanup` to avoid any use-after-free?

markj accepted this revision as: markj.Dec 9 2022, 4:53 PM

jhb added inline comments.Dec 9 2022, 5:28 PM

sys/amd64/vmm/vmm.c
670	We are about to `free(vm)` in the caller after this function returns in the `destroy` case, so use-after-free isn't really possible I think.

Closed by commit rGaf3b48e10198: vmm: Free vCPUs when destroying them. (authored by jhb). · Explain WhyDec 9 2022, 6:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGaf3b48e10198: vmm: Free vCPUs when destroying them..

jhb added a commit: rGc44d097dcf92: vmm: Free vCPUs when destroying them..Jan 26 2023, 10:18 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

vmm.c

1 line

Diff 113969

View Options

vmm: Free vCPUs when destroying them.ClosedPublicActions