fwcontrol: Disable -Wzero-length-bounds warnings.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:51 PM.

Details

Reviewers

emaste
imp

Commits

rG0345952b9e44: fwcontrol: Disable -Wzero-length-bounds warnings.
rGaa9ce62be54f: fwcontrol: Disable -Wzero-length-bounds warnings.

Summary

firewire.h includes zero length arrays in unions that trigger this
warning.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 29 2022, 7:51 PM

jhb created this revision.

Harbormaster completed remote builds in B48539: Diff 113625.Nov 29 2022, 7:51 PM

jhb added a parent revision: D37537: bsd.sys.mk: Add NO_WZERO_LENGTH_BOUNDS helper variable..Nov 29 2022, 7:51 PM

We likely should rework those, but firewire is on deck for retirement...

This revision is now accepted and ready to land.Nov 29 2022, 8:16 PM

Agree it doesn't make sense to spend effort on fixing firewire, it will just be retired in the future.

In D37538#853717, @emaste wrote:

Agree it doesn't make sense to spend effort on fixing firewire, it will just be retired in the future.

The pattern also isn't easy to fix. I have slightly less kind words later in my patches when I get to the kernel where I have to disable this warning for the entire kernel due to the OFED and Mellanox drivers using zero length array members of structs as a horrible hack.

Closed by commit rGaa9ce62be54f: fwcontrol: Disable -Wzero-length-bounds warnings. (authored by jhb). · Explain WhyDec 5 2022, 12:31 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGaa9ce62be54f: fwcontrol: Disable -Wzero-length-bounds warnings..

jhb added a commit: rG0345952b9e44: fwcontrol: Disable -Wzero-length-bounds warnings..May 3 2023, 12:30 AM