Page MenuHomeFreeBSD

virtio: Silence a -Wunused warning
ClosedPublic

Authored by markj on Nov 6 2022, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 25, 10:03 AM
Unknown Object (File)
Tue, Apr 22, 3:41 AM
Unknown Object (File)
Tue, Apr 22, 2:40 AM
Unknown Object (File)
Mon, Apr 21, 12:52 PM
Unknown Object (File)
Sun, Apr 20, 10:30 PM
Unknown Object (File)
Sat, Apr 19, 4:34 PM
Unknown Object (File)
Thu, Apr 10, 5:55 AM
Unknown Object (File)
Sat, Apr 5, 12:09 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Nov 6 2022, 10:49 PM
corvink added inline comments.
sys/dev/virtio/virtio_endian.h
44–45

This function looks like a small optimization. I don't think that this optimization makes sense because it makes the code harder to read for no value.
So IMHO, we should drop it. E.g. just use:

static inline uint16_t
virtio_htog16(bool modern, uint16_t val)
{
  if (modern)
    return (htole16(val));
  else
    return (val);
}
jhb added inline comments.
sys/dev/virtio/virtio_endian.h
44–45

I agree with Corvin's suggestion and think it is more readable.

markj marked 2 inline comments as done.

Remove virtio_swap_endian().

This revision is now accepted and ready to land.Nov 14 2022, 6:21 AM
This revision was automatically updated to reflect the committed changes.