Page MenuHomeFreeBSD

bhyve: Drop volatile qualifiers from xhci hw struct fields
ClosedPublic

Authored by markj on Nov 6 2022, 7:36 PM.
Tags
None
Referenced Files
F106334836: D37290.id112698.diff
Sat, Dec 28, 9:35 PM
Unknown Object (File)
Nov 17 2024, 11:55 AM
Unknown Object (File)
Nov 8 2024, 9:38 PM
Unknown Object (File)
Oct 21 2024, 5:18 PM
Unknown Object (File)
Oct 2 2024, 4:38 PM
Unknown Object (File)
Sep 27 2024, 5:25 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 3:25 PM
Subscribers

Details

Summary

This fixes a warning raised by the removal of the volatile qualifier
from &trb->qwTrb0 in the following snippet:

xfer_block = usb_data_xfer_append(xfer,

	     (void *)(trbflags & XHCI_TRB_3_IDT_BIT ?
		 &trb->qwTrb0 : XHCI_GADDR(sc, trb->qwTrb0)),
	     trb->dwTrb2 & 0x1FFFF, (void *)addr, ccs);

The use of volatile appears to be inherited from the kernel driver's
definitions of the same structures. It makes some sense, since USB TRBs
and related structures live in guest memory, but bhyve device models
generally don't volatile-qualify accesses to guest memory and I can't
see how they are required for correctness here. Moreover, XHCI_GADDR
does not return volatile pointers so we're already being inconsistent.
So just drop the qualifiers to address the warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable