bhyveload: open guest boot disk image O_RDWR
ClosedPublic
Actions

Authored by rew on Nov 4 2022, 10:16 PM.

Details

Reviewers

markj
imp
jhb

Group Reviewers

bhyve

Commits

rGb0bd185dc3f0: bhyveload: open guest boot disk image O_RDWR
rG5a023bd2a53a: bhyveload: open guest boot disk image O_RDWR

Summary

When a boot environment has been booted via the bootonce feature,
userboot clears the bootonce value from an nvlist but fails to write the
updated nvlist back to disk.

The failure occurs because bhyveload opens the guest boot disk image
O_RDONLY, fix this by opening it O_RDWR.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Nov 4 2022, 10:16 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 4 2022, 10:16 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rew requested review of this revision.Nov 4 2022, 10:16 PM

Harbormaster completed remote builds in B48166: Diff 112629.Nov 4 2022, 10:16 PM

Seems reasonable to me.

This revision is now accepted and ready to land.Nov 5 2022, 3:57 PM

Keeping it read-only might be good to ensure we're not changing the image... But that seems like too fine a detail to control via an option, and I've not looked to see how careful other things are... So, seems fine overall, but I thought I'd mention this in case I've missed something...