Page MenuHomeFreeBSD

inpcb: don't return INP_DROPPED entries from pcb lookups
ClosedPublic

Authored by glebius on Oct 19 2022, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 1:57 PM
Unknown Object (File)
Thu, Nov 7, 9:02 AM
Unknown Object (File)
Thu, Nov 7, 1:29 AM
Unknown Object (File)
Mon, Oct 21, 6:21 PM
Unknown Object (File)
Wed, Oct 16, 2:04 PM
Unknown Object (File)
Tue, Oct 15, 1:17 PM
Unknown Object (File)
Oct 12 2024, 2:13 PM
Unknown Object (File)
Oct 11 2024, 5:40 AM

Details

Summary

The in_pcbdrop() KPI, which is used solely by TCP, allows to remove a
pcb from hash list and mark it as dropped. The comment suggests that
such pcb won't be returned by lookups. Indeed, every call to
in_pcblookup*() is accompanied by a check for INP_DROPPED. Do what
comment suggests: never return such pcbs and remove unnecessary checks.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47922
Build 44809: arc lint + arc unit

Event Timeline

tuexen added inline comments.
sys/netinet/tcp_lro.c
1361

Maybe also remove the comment?

sys/netinet/tcp_lro.c
1361

It still applies to the (tp == NULL) check. Which is going to be addressed later, and that would remove the comment, too.

This revision is now accepted and ready to land.Oct 20 2022, 9:27 AM