Page MenuHomeFreeBSD

inpcb: don't return INP_DROPPED entries from pcb lookups
ClosedPublic

Authored by glebius on Oct 19 2022, 10:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 5:35 PM
Unknown Object (File)
Sun, Mar 23, 9:25 PM
Unknown Object (File)
Tue, Mar 18, 10:33 PM
Unknown Object (File)
Feb 4 2025, 4:16 AM
Unknown Object (File)
Feb 3 2025, 12:07 PM
Unknown Object (File)
Jan 27 2025, 5:01 PM
Unknown Object (File)
Jan 24 2025, 5:36 PM
Unknown Object (File)
Jan 24 2025, 1:05 PM

Details

Summary

The in_pcbdrop() KPI, which is used solely by TCP, allows to remove a
pcb from hash list and mark it as dropped. The comment suggests that
such pcb won't be returned by lookups. Indeed, every call to
in_pcblookup*() is accompanied by a check for INP_DROPPED. Do what
comment suggests: never return such pcbs and remove unnecessary checks.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen added inline comments.
sys/netinet/tcp_lro.c
1362

Maybe also remove the comment?

sys/netinet/tcp_lro.c
1362

It still applies to the (tp == NULL) check. Which is going to be addressed later, and that would remove the comment, too.

This revision is now accepted and ready to land.Oct 20 2022, 9:27 AM